Detect stale and incomplete LRAUV deployment plot outputs before skipping reprocessing - #201
Merged
Conversation
…ping reprocessing _deployment_has_outputs() previously only checked for the presence of any output PNG, so a new .nc log file added to an already-processed deployment (or a plot kind that silently failed to generate) was never picked up by subsequent --last_n_days runs. It now also requires every output PNG to have its HTML sibling, every source nc file to be no newer than the existing outputs (via local stat or an HTTP Last-Modified check), and every plot kind with per-log data to have a matching combined-deployment PNG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_deployment_has_outputs() previously only checked for the presence of any output PNG, so a new .nc log file added to an already-processed deployment (or a plot kind that silently failed to generate) was never picked up by subsequent --last_n_days runs. It now also requires every output PNG to have its HTML sibling, every source nc file to be no newer than the existing outputs (via local stat or an HTTP Last-Modified check), and every plot kind with per-log data to have a matching combined-deployment PNG.