Conversation
helly25
force-pushed
the
implement/arena-string-storage
branch
2 times, most recently
from
September 18, 2026 07:45
ad8c244 to
00f06e6
Compare
helly25
force-pushed
the
implement/arena-string-storage
branch
from
September 18, 2026 08:44
00f06e6 to
34c0063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an Arena-backed string ownership adapter that copies bytes once, returns stable
std::string_views, and can roll back an uncommitted copy when another interner component fails. This supplies the byte-storage half of bounded, allocation-controlled string interning without coupling storage to indexing or ID assignment.AG;DR
ArenaStringStorage, parameterized by an Arena-compatible type.std::string_views and preserve embedded NUL bytes.std::nullopt.Validation:
bazel --output_user_root=/private/tmp/mbo-arena-string-storage-bazel test //mbo/strings:arena_string_storage_testThis PR is stacked on #494.