Run ThinLTO release smoke tests in parallel - #779
Closed
helly25 wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by #780 after timing showed that one complete production ThinLTO test build has comparable wall time, substantially lower runner cost, and avoids configuration drift. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default opt tests and ThinLTO release smoke builds now run in parallel instead of serially in the same Linux and macOS jobs. This preserves validation of the exact shipped binaries while aiming to remove the release-build tail from required CI wall time.
AG;DR
Change
release smokejobs.donejob require the new release-smoke matrix.Timing hypothesis
The final PR 777 run serialized these phases:
The split is worthwhile if each new release-smoke cell finishes no later than its matching default-test cell, after accounting for independent setup and cache behavior. This PR's CI run is the acceptance measurement. If that condition does not hold, the next experiment is running the complete suite under ThinLTO and comparing its wall time.
Validation
tools/release_prep_test.shgit diff --check origin/main...HEADpre-commit run --files .github/workflows/main.ymlNo test scope or release transformation is removed; only scheduling and cache ownership change.