Constrain config skip permissions - #810
Merged
Merged
Conversation
helly25
force-pushed
the
config/config-control-policy
branch
2 times, most recently
from
September 11, 2026 12:11
aeb8b2d to
6a5d839
Compare
helly25
force-pushed
the
config/config-control-policy
branch
from
September 11, 2026 12:25
6a5d839 to
e34f31b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make configuration admission and skip authorization explicit, revocable, and scoped to the configuration source that owns each decision. Combined and granular skip requests no longer accidentally authorize one another, while named config sets can control whether explicit xffrc files are accepted.
AG;DR
--no-configas a distinct combined request instead of irreversibly reducing it to the two granular booleans.--allow-no-config/--no-allow-no-config; this pair governs only--no-config.--allow-no-system-config/--no-allow-no-system-config; this pair governs only--no-system-config.--allow-no-user-config/--no-allow-no-user-config; the system decision is authoritative, otherwise the user file may decide whether--no-user-configis permitted.--xffrcfiles.--allow-xffrc/--no-allow-xffrc. These are ordinary config-only settings usable in system defaults or any user config block; normal selection and precedence decide whether command-line--xffrc=FILEis accepted.XFF.md, and the changelog.Validation:
bazel test //xff/config:ini_test //xff/config:loader_test //xff/config:policy_test //xff/config:config_test --config=clangbazel test //xff/config:policy_test //xff/config:config_policy_fuzz_test --config=clangbazel test //xff/cli:explain_test --config=clang --test_output=errorsXFF.mdwas regenerated after the final wording and matches its generated artifact.git diff --checkA separate follow-up will add registry-backed repetition metadata and report unnecessary overriding settings within individual config sections. Deliberately accumulating settings and command-line repetitions remain unaffected.