Skip to content

Flaky Editor e2e: feedback restores focus after Escape #576

Closed

Description

@callumalpass

apps/editor/tests/feedback.spec.ts:118 — feedback keeps application shortcuts out and restores the draft/focus after Escape — intermittently fails at line 127:

await expect(dialog).not.toBeVisible(); await expect(entry).toBeFocused();
Error: expect(locator).toBeFocused() failed

Seen three times on 2026-10-03, each passing on rerun with no related change:

Playwright runs fail-on-first-error (docs/ci-flakes.md), so this blocks merges and the tagged production Editor publication until it's rerun. Likely a race between the dialog closing and focus being restored to the entry. The fix should wait on the actual focus-restoration signal rather than add a retry or a longer timeout.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions