Repository navigation
Add inactive shared-runtime mutation backend (port 1/n) - #28
Merged
Merged
Conversation
Collaborator
Author
|
security: no blocking findings — security-2, on head a5cc742, for this inactive seam only. Collection/path-class checks precede client mutation, rejected/held writes have no vault-write fallback, and old mirror/adoption/in-flight Connect work blocks attachment. No startup or user setting activates it. Activation remains a separate reviewed change: fence all asynchronous legacy mutation paths and callbacks, track backend writes through detach/rehome/shutdown, use real published receipts/CAS, and test path mapping plus runtime exclusivity on desktop/mobile. Source review only; reported tests were not rerun here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a structural SdkWriteClient seam for typed-note creates, quick fixes and same-path type edits/creates. No setting or startup path enables it; today’s Connect remains the default. Holds/rejections propagate with no vault-write fallback. Old mirror/adoption profiles and in-flight operations block attachment; subsequent legacy operations and unported packs/migration/initialization/rename fail closed while attached.
Checks: typecheck/build, lint (zero warnings), 444 unit tests passed (one existing TODO), lossless mock/reference 10 exact round trips, mobile bundle check passed. Ten new tests. No real-runtime, desktop/mobile end-to-end or migration run. Activation/Worker/registry/daemon integration remains dependent on mdbase-next SDK host ABI and published receipts.
Coordinator merges; security review requested for path classification and runtime exclusivity guards.