Skip to content

Style native sign-in controls with existing Reader buttons #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
callumalpass merged 1 commit into from
Oct 10, 2026
Merged

Style native sign-in controls with existing Reader buttons #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/reader/src/NativeSignIn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ function NativeSignInView({ binding, onSignedOut }: NativeSignInProps): JSX.Elem
<div className="connection-actions">
{view.waiting ? (
<button
className="text-action"
className="mdbase-button"
type="button"
disabled={working}
onClick={() => void act(authorize)}
Expand All @@ -125,7 +125,7 @@ function NativeSignInView({ binding, onSignedOut }: NativeSignInProps): JSX.Elem
</button>
) : !view.paired || view.error ? (
<button
className="connection-connect"
className="mdbase-connect-action"
type="button"
disabled={working || view.disabled}
onClick={() => void act(authorize)}
Expand All @@ -135,7 +135,7 @@ function NativeSignInView({ binding, onSignedOut }: NativeSignInProps): JSX.Elem
) : null}
{view.paired ? (
<button
className="text-action"
className="mdbase-button"
type="button"
disabled={working}
onClick={() => void act(signOut)}
Expand All @@ -145,7 +145,7 @@ function NativeSignInView({ binding, onSignedOut }: NativeSignInProps): JSX.Elem
) : null}
{snapshot.selectedCollectionId ? (
<button
className="text-action"
className="mdbase-button"
type="button"
disabled={working}
onClick={() => {
Expand Down
4 changes: 3 additions & 1 deletion docs/new-sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ it does not guess them or replace the default Connect/extension runtimes.

Sign in reserves the tab in the user gesture before asynchronous SDK start or
expiry renewal. The SDK owns approval detection and protected state. The UI uses
canonical status/email, reopen-tab, popup-blocked and interrupted wording. It
canonical status/email, reopen-tab, popup-blocked and interrupted wording. Sign-in
and secondary actions reuse Reader's existing shared control styles, including
usable touch targets at 390px. It
shows only states the SDK can distinguish, not a fabricated decline or setup
result. Sign out waits for SDK close; it is local shutdown, not membership
revocation or protected-store deletion. Forget uses the actual selected SDK ID.
Expand Down