Repository navigation
Compare embedded Reader resources against Reader's main - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Reader drift test read the sibling
mdbase-readercheckout's working tree, so it failed whenever that checkout was on a feature branch, even though Writer's copies match Reader's main. It also crashed onceupgradeFrombecame a list of paths.It now reads each resource with
git show origin/main:apps/reader/mdbase/<path>and iterates over theupgradeFromlist. It is still skipped when there is no sibling Reader checkout, as in CI.Testing:
node --test scripts/manifest.test.mjspasses (9 passed, 1 skipped) with the local Reader checkout on a feature branch that differs from main.