Skip to content

Last parameters are inherited #19

Description

@gioamato

Noticed just now that the utm and additional last parameters are not true but inherited. E.g.:

Visit 1: utm_parameter=1
cookie value = 1
form value = 1

Visit 2: utm_parameter=2
cookie value = 2
form value = 2

Visit 3: utm_parameter missing
cookie value = 2 (inherited)
form value = 2 (inherited)

This is caused by the check if (this.utmPresentInUrl()) inside the UtmCookie class constructor. Same applies to additional parameters because of if (this.additionalParamsPresentInUrl()).

Should the condition be removed? So the utm and additional last parameters will be null if not present and the resulting data will be more consistent. Otherwise an option to track last values can be added and if true it will write utm and additional last parameters with null values if not present inside the URL.

@medius what do you think about that?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions