Conversation
SwingLab-Setup.exe installs an onedir build with the Vue UI, OpenCV, and MediaPipe. First launch opens the camera wizard; user data and recordings go to %LOCALAPPDATA%\SwingLab. Build with python scripts/build_installer.py or the Windows installer workflow. Co-authored-by: John Menke <jmjava@gmail.com>
Point Windows helpers at the setup wizard instead of deleted debug_recorder.py. Archive copies only the active player's swings (plus unclaimed). Inno no longer sets empty LicenseFile/icon keys. SwingDetector tests mock time instead of sleeping. Co-authored-by: John Menke <jmjava@gmail.com>
cursor
Bot
changed the title
jmjava
marked this pull request as ready for review
August 16, 2026 01:24
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
JSON error payloads now use 4xx/5xx instead of HTTP 200. Saved-swing clip export re-encodes the recording from disk when annotated frames are no longer in memory. The mock soak no longer sleeps on the clock. Co-authored-by: John Menke <jmjava@gmail.com>
The users API fixture has no CameraManager; a 200-with-error used to hide that. Fail closed like the other uninitialized routes. Co-authored-by: John Menke <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #13 merged the source setup wizard, but the PyInstaller + Inno Setup commit stayed behind. This PR puts that installer on
masterand closes leftover holes from the GUI retirement.Windows installer
dist\SwingLab\SwingLab.exedist\installer\SwingLab-Setup-1.1.0.exeInstalls to
%LOCALAPPDATA%\Programs\SwingLab. Recordings go to%LOCALAPPDATA%\SwingLab. GitHub Action Windows installer builds onv*tags or manual dispatch. See packaging/README.md.Loose ends in this PR
setup_env.ps1/.bat,run_debug.ps1, andmove_project.ps1no longer call deleteddebug_recorder.pyLicenseFile/SetupIconFileSwingDetectortests mocktime.timeinstead ofsleepTestTemplate*names removed from test runnersStability / product bugs
503not initialized,409recording conflicts,403other-player delete,404missing camera/recording) instead of HTTP 200 with{error}sleepjsonFetchtreats a payloaderrorfield as failure even if a route still returns 200Tests
python3 run_all_tests.py --unitpassed. Frontend Vitest (35) and Playwright e2e (8) passed.