Scope engine data access to the executing app - #330
Merged
Merged
Conversation
merlinfuchs
force-pushed
the
merlin/tenant-scoping
branch
from
September 23, 2026 21:27
e4a336f to
7ae8f97
Compare
merlinfuchs
changed the title
merlinfuchs
force-pushed
the
merlin/tenant-scoping
branch
from
September 23, 2026 21:34
7ae8f97 to
66ab9a6
Compare
merlinfuchs
force-pushed
the
merlin/tenant-scoping
branch
from
September 23, 2026 21:38
66ab9a6 to
00fe163
Compare
merlinfuchs
force-pushed
the
merlin/tenant-scoping
branch
from
September 23, 2026 21:41
00fe163 to
3f0234e
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine looked up variable values, message templates, message instances and resume points by ID alone, and those IDs come from user-authored flow data or custom IDs, so one app could read or write another app's data. Queries now scope by app, joining through
variables/messagesfor the two tables without anapp_id.The instance upsert from #361 now also refuses to re-link another app's instance.
queries_scoping_test.gofails any query that touchesvariable_valuesormessage_instanceswithout mentioningapp_id, since there's no DB in tests.