Skip to content

fix: migrate federated identity credential to azurerm v5 schema - #237

Merged
malhussan merged 1 commit into
mainfrom
fix/azurerm-v5-compat
Jul 29, 2026
Merged

fix: migrate federated identity credential to azurerm v5 schema#237
malhussan merged 1 commit into
mainfrom
fix/azurerm-v5-compat

Conversation

@malhussan

Copy link
Copy Markdown
Member

azurerm v5 removed parent_id/resource_group_name in favour of user_assigned_identity_id, which landed in 4.65.0 — hence the floor bump.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Scorecard Check

Scorecard run on commit 43ff394b1178c5214b2620aaa25c1e0af5de6fd6 relative to origin/main

📊 meshstack-hub Module Scorecard

Generated: 2026-07-29 | Modules scanned: 5 | Categories: 5

📋 Per-Module Category Summary

Score per category per building block. n/a = category does not apply to this module.

Module Overall Core Structure Integration Azure Backplane STACKIT Backplane Testing
azure/budget-alert 🟢 100% 🟢 100% 🟢 100% 🟢 100% n/a 🟢 100%
azure/entra-id-groups 🟢 94% 🟢 100% 🟢 100% 🟢 100% n/a 🔴 33%
azure/github-actions-terraform-setup 🔴 47% 🟢 86% n/a 🔴 22% n/a 🔴 33%
azure/resource-group 🟢 100% 🟢 100% 🟢 100% 🟢 100% n/a 🟢 100%
azure/storage-account 🟢 100% 🟢 100% 🟢 100% 🟢 100% n/a 🟢 100%

⚠️ 2 modules have failing checks — failing categories are expanded below.

Core Structure — some checks failing

Basic module file structure and documentation — applies to 5 modules

Module Score 📦 🔗 📋 📝 🖼️ 📌 🔒
azure/budget-alert 🟢 100%
azure/entra-id-groups 🟢 100%
azure/github-actions-terraform-setup 🟢 86%
azure/resource-group 🟢 100%
azure/storage-account 🟢 100%

Core Structure — Summary

Emoji Criterion Coverage Status
📦 buildingblock/ directory exists 5/5 🟢 100%
🔗 meshstack_integration.tf present 4/5 🟢 80%
📋 buildingblock/APP_TEAM_README.md present (no-integration fallback) 1/1 🟢 100%
📝 buildingblock/README.md with YAML front-matter 5/5 🟢 100%
🖼️ buildingblock/logo.png included 5/5 🟢 100%
📌 buildingblock/versions.tf present 5/5 🟢 100%
🔒 Provider versions use minimum constraint (>=) 5/5 🟢 100%
Integration — ✅ all passing

meshstack_integration.tf conventions — applies to 4 modules

Module Score 🏷️ 🏢 📤 🔌 📎 🔀 📋 🏷️ 🧱 📖 📝 📊 🚫 🔄
azure/budget-alert 🟢 100%
azure/entra-id-groups 🟢 100%
azure/resource-group 🟢 100%
azure/storage-account 🟢 100%

Integration — Summary

Emoji Criterion Coverage Status
🏷️ variable "hub" in integration 4/4 🟢 100%
🏢 variable "meshstack" in integration 4/4 🟢 100%
📤 building_block_definition output exposed 4/4 🟢 100%
🔌 meshcloud/meshstack in required_providers 4/4 🟢 100%
📎 backplane source uses var.hub.git_ref 4/4 🟢 100%
🔀 ref_name uses var.hub.git_ref 4/4 🟢 100%
📋 version_spec.draft uses var.hub.bbd_draft 4/4 🟢 100%
🏷️ BBD metadata.tags forwards var.meshstack.tags 4/4 🟢 100%
🧱 BBD input argument vars with optional() have explicit defaults 4/4 🟢 100%
📖 BBD readme field present 4/4 🟢 100%
📝 BBD readme starts with plain-text description (no heading) 4/4 🟢 100%
📊 BBD readme has shared responsibility table (✅/❌) 4/4 🟢 100%
🚫 No documentation_md output in backplane 4/4 🟢 100%
🔄 meshstack_platform has lifecycle ignore_changes = [availability] n/a
Azure Backplane — some checks failing

Azure UAMI-based automation principal conventions — applies to 5 modules

Module Score 🪪 🚫 🚫 🔑 🔗 🧹 📤 📍
azure/budget-alert 🟢 100%
azure/entra-id-groups 🟢 100%
azure/github-actions-terraform-setup 🔴 22%
azure/resource-group 🟢 100%
azure/storage-account 🟢 100%

Azure Backplane — Summary

Emoji Criterion Coverage Status
🪪 Uses azurerm_user_assigned_identity 4/5 🟢 80%
🚫 No azuread_application resources 4/5 🟢 80%
🚫 No azuread_service_principal resources 4/5 🟢 80%
🔑 No azuread_application_password resources 5/5 🟢 100%
🔗 Uses azurerm_federated_identity_credential 4/5 🟢 80%
workload_identity_federation is non-nullable 4/5 🟢 80%
🧹 No create_service_principal_name toggle 5/5 🟢 100%
📤 Outputs identity (client_id, principal_id, tenant_id) 4/5 🟢 80%
📍 Integration has azure_location 4/5 🟢 80%
STACKIT Backplane — not applicable

STACKIT WIF-based automation principal conventions — applies to 0 modules

No applicable modules.

Testing — some checks failing

End-to-end test coverage — applies to 5 modules

Module Score ⚙️ 🧪
azure/budget-alert 🟢 100%
azure/entra-id-groups 🔴 33%
azure/github-actions-terraform-setup 🔴 33%
azure/resource-group 🟢 100%
azure/storage-account 🟢 100%

Testing — Summary

Emoji Criterion Coverage Status
⚙️ backplane/ directory (optional tier) 5/5 🟢 100%
🧪 e2e/ test directory exists 3/5 🟡 60%
e2e/ contains .tftest.hcl files 3/5 🟡 60%

📈 Overall Summary

Overall Average Score: 88%

Score Distribution

  • 🟢 High maturity (≥80%): 4 modules
  • 🟡 Medium maturity (50–79%): 0 modules
  • 🔴 Low maturity (<50%): 1 modules

azurerm v5 removed `parent_id`/`resource_group_name` in favour of
`user_assigned_identity_id`, which landed in 4.65.0 — hence the floor bump.
@aws-amplify-eu-central-1

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-237.d1o16zfeoh2slu.amplifyapp.com

@malhussan
malhussan force-pushed the fix/azurerm-v5-compat branch from 7165807 to 611554a Compare July 29, 2026 12:25
@malhussan
malhussan merged commit 1042c12 into main Jul 29, 2026
3 checks passed
@malhussan
malhussan deleted the fix/azurerm-v5-compat branch July 29, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants