Repository navigation
Always write IVCSC/IVCSR; remove format option from write_h5ad - #65
Merged
Merged
Conversation
…ite_h5ad/write_zarr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_h5adno longer takes aformatargument:X/raw_Xare always stored as IVCSC (from VCSC) or IVCSR (from VCSR), so there is a single on-disk format.formatfromwrite_zarras well, since both share_write_group; leaving it would keep a second format reachable.vcscfiles still load.docs/usage.md, docstrings and tests (dropped the bad-format test and the vcsc/ivcsc parametrization).Note
Both methods keep a
**_kwargscatch-all, so a staleformat=...argument is silently ignored rather than raising. Say if you'd rather that be stricter.