Repository navigation
Give the dashboard task MDredd's URL and API token - #229
Merged
Merged
Conversation
Judging (#228) needs MDREDD_API_URL and MDREDD_API_TOKEN to reach MDredd. The token comes from the SSM parameter infra created for MDredd; the dashboard's execution role can read it once mhacks/infra#13 is applied. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Judging (#228) needs two settings to reach MDredd:
MDREDD_API_URL=https://mdredd.mhacks.org, a plain environment value.MDREDD_API_TOKEN, from/mhacks-secrets/MDREDD_API_TOKEN. That's the SSM parameter mhacks/infra#11 created for MDredd.Don't merge until mhacks/infra#13 is applied. Until then, the dashboard's execution role can't read the MDredd token. ECS would fail to start the new task, and the deploy's circuit breaker would roll back.
Also deploy MDredd (mhacks/MDredd#27) first. Then check that
https://mdredd.mhacks.org/healthreturns 200. If MDredd isn't up, the judging pages show "Could not reach the judging server" instead of failing.Test plan
https://mdredd.mhacks.org/healthreturns 200/admin/teams/judgingloads without the "not set up" message.🤖 Generated with Claude Code