feat: detect screen SafeArea ownership for Flutter guidance - #53
Open
PacteraSunChao wants to merge 1 commit into
Open
PacteraSunChao wants to merge 1 commit into
PacteraSunChao wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScreenSafeAreaInfoon screen layout analysis output.SafeAreaonly for unhandled edges, and routes footer sections tobottomNavigationBar.Motivation
Design frames often omit system insets. Without explicit safe-area ownership, agents either hardcode design insets into component heights or wrap the whole screen blindly. This change records whether the screen itself must handle the top inset, and emits matching Flutter guidance.
Changes
ScreenSafeAreaInfoand attach optionalsafeAreatoScreenLayoutInfo.detectScreenSafeArea()returns{ top: { required: true, reason: 'no-app-bar' } }when no App Bar is detected.SafeAreawithtop/bottomdisabled when AppBar/footer already occupy those edges.Test plan
npm run buildsucceedsTop Safe Area: Required at runtimeSafeArea(top: false, ...)when only bottom needs protectionbottomNavigationBar, not inside body children