fix(root): show notice when JavaScript is disabled - #1894
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Contributor
|
Please can you rebase this pull request? |
sylvesterkaczmarek
force-pushed
the
fix/186-no-js-notice
branch
from
August 21, 2026 20:19
7ad0238 to
804668a
Compare
Contributor
Author
|
Rebased onto the latest develop. Thanks! |
GCHQ-Developer-299
requested changes
Aug 28, 2026
GCHQ-Developer-299
left a comment
Contributor
There was a problem hiding this comment.
From my understanding, this ticket requests that an alert be added to every page that warns users about disabling javascript, while still displaying the page below.
This full replacement of the site with a message does not fulfil the requirements
sylvesterkaczmarek
force-pushed
the
fix/186-no-js-notice
branch
from
September 15, 2026 10:23
781bd7f to
e6f463c
Compare
Contributor
Author
|
Thanks for the review. I’ve updated this so the |
GCHQ-Developer-112
force-pushed
the
develop
branch
from
September 21, 2026 15:45
069fb2e to
3230dbf
Compare
sylvesterkaczmarek
force-pushed
the
fix/186-no-js-notice
branch
from
September 23, 2026 11:21
e6f463c to
cf2d655
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a site-wide notice for users browsing the guidance site with JavaScript disabled.
The notice is rendered within the SSR layout using a native
<noscript>element, so the existing page remains visible below it when JavaScript is unavailable.Change
Closes #186