Skip to content

fix(web-components): #4451 preserve dialog content semantics - #4625

Open
sylvesterkaczmarek wants to merge 2 commits into
mi6:developfrom
sylvesterkaczmarek:fix/4451-dialog-aria-description
Open

sylvesterkaczmarek wants to merge 2 commits into
mi6:developfrom
sylvesterkaczmarek:fix/4451-dialog-aria-description

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Summary of the changes

Remove the forced aria-describedby from IcDialog's native dialog element so structured slotted content is not flattened into a single screen-reader description.

This keeps aria-labelledby for the dialog heading/label and allows links and other semantic content to remain navigable.

Added:

  • unit regression coverage with structured dialog content and a link
  • React/Cypress accessibility coverage confirming aria-describedby is omitted, heading labelling is preserved, the slotted link remains focusable, and axe passes

This follows WAI-ARIA APG guidance to omit aria-describedby when dialog content contains semantic structures that need to be navigated.

Related issue

Closes #4451

Comment thread packages/react/src/component-tests/IcDialog/IcDialogAriaDescription.cy.tsx Outdated
@sylvesterkaczmarek
sylvesterkaczmarek force-pushed the fix/4451-dialog-aria-description branch from 1227b35 to 28505e4 Compare August 21, 2026 21:14
Comment thread packages/react/src/component-tests/IcDialog/IcDialog.cy.tsx
Comment thread packages/react/src/component-tests/IcDialog/IcDialog.cy.tsx
@sylvesterkaczmarek
sylvesterkaczmarek force-pushed the fix/4451-dialog-aria-description branch 2 times, most recently from ccb8f31 to c204b7a Compare August 24, 2026 17:11
@sylvesterkaczmarek
sylvesterkaczmarek force-pushed the fix/4451-dialog-aria-description branch from c204b7a to def4730 Compare September 15, 2026 15:09
@sylvesterkaczmarek

Copy link
Copy Markdown
Author

Thanks. I’ve rebased this onto current develop, split the change into web-components and react commits, regenerated the 12 snapshots affected by removing the dialog aria-describedby, and fixed the Cypress assertion chaining issue. The full web-component suite passes with the updated snapshots, the focused structured-content Cypress regression passes, and Prettier, Commitlint, the scope checker, and both package builds pass. CLA is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants