Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
ob-rustcurrently looks for the exact stringfn main()before deciding whether to wrap a Rust source block in a generatedmainfunction.Valid Rust formatting with whitespace in the declaration can therefore go undetected and cause the block to be wrapped in an extra
main.This change makes
maindetection tolerate whitespace betweenfnandmain, and before the opening parenthesis.The existing behavior for blocks without a
mainfunction is unchanged.Regression coverage is added to the existing
ob-rusttest suite for both whitespace cases while preserving the existing wrapper behavior.Tests:
make test— 5/5 passed.