Move the workflow actions to the Node 24 runtime - #48
Merged
Merged
Conversation
Every run printed the same deprecation notice and was forced onto Node 24 regardless, so the pins were buying nothing but the warning. checkout v4 to v7, setup-python v5 to v7, action-gh-release v2 to v3, codecov-action v5 to v7 -- the latest major of each, which is where dependabot would have landed anyway. Checked what the new majors dropped before jumping, because a major bump taken on faith is how a release workflow breaks at the one moment you need it: checkout v7 only restricts checking out a forked PR under `pull_request_target` and `workflow_run`, neither of which appears here, and setup-python v7 removed the `pip-install` input, which nothing used. `cache: pip`, `body_path`, `files`, `token` and `fail_ci_if_error` are all unchanged. Also restores the `## [Unreleased]` header that folding 1.0.0 removed. AGENTS.md tells every change to write its entry under it, and it was not there to write under. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 19 19
Lines 1048 1048
Branches 119 119
=======================================
Hits 967 967
Misses 65 65
Partials 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every run was printing the same deprecation notice and being forced onto Node 24 anyway,
so the old pins bought nothing but the warning.
actions/checkoutactions/setup-pythonsoftprops/action-gh-releasecodecov/codecov-actionpypa/gh-action-pypi-publish@release/v1is a Docker action and never had the problem.What the new majors dropped
Worth checking rather than assuming, since
release.ymlis the one workflow that breaksat the moment you need it most:
pull_request_targetandworkflow_run. Neither trigger appears here.pip-installinput. Nothing used it;cache: pipisunchanged.
body_pathandfilesunchanged.token,filesandfail_ci_if_errorunchanged.Also
Restores the
## [Unreleased]header that folding the 1.0.0 release removed. AGENTS.mdtells every change to write its entry under it, and it was not there to write under.
./scripts/verify.shpasses.🤖 Generated with Claude Code