Skip to content

feat(core): re-export puppeteer Page types - #66

Merged
Kikobeats merged 2 commits into
masterfrom
feat/inline-function-page
Sep 20, 2026
Merged

feat(core): re-export puppeteer Page types#66
Kikobeats merged 2 commits into
masterfrom
feat/inline-function-page

Conversation

@Kikobeats

@Kikobeats Kikobeats commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Re-export Page and HTTPResponse from puppeteer-core so import type { Page } from 'microlink.io' uses the real Puppeteer types.
  • FunctionArgs.page stays Page & { metadata; extract }.

Test plan

  • pnpm exec tsd in packages/core
  • Website editor generates Monaco types from the same puppeteer-core dts

@Kikobeats @cursoragent
feat(core): export function Page types
97a59e7 
Editor completions cannot resolve puppeteer-core, so Page and
HTTPResponse live in microlink.io itself.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: bc2daf4f-c2ab-474d-a959-2493be1cf120

📥 Commits

Reviewing files that changed from the base of the PR and between cf27fdc and 1bc0abc.

📒 Files selected for processing (2)
  • packages/core/src/index.d.ts
  • packages/core/test/index.test-d.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

coveralls commented Sep 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Report for CI Build 35525097586

Warning

No base build found for commit cf27fdc on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 80.893%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →

Coverage Stats

Coverage Status
Relevant Lines: 5718
Covered Lines: 4647
Line Coverage: 81.27%
Relevant Branches: 955
Covered Branches: 751
Branch Coverage: 78.64%
Branches in Coverage %: Yes
Coverage Strength: 27.84 hits per line
💛 - Coveralls

@Kikobeats @cursoragent
fix(core): re-export puppeteer Page types
1bc0abc 
Copying a Page stub into microlink.io duplicated puppeteer-core.
Re-export the real types so the editor can generate from the same dts.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Kikobeats Kikobeats changed the title feat(core): export function Page types feat(core): re-export puppeteer Page types Sep 20, 2026
@Kikobeats
Kikobeats merged commit 1d408a9 into master Sep 20, 2026
9 checks passed
@Kikobeats
Kikobeats deleted the feat/inline-function-page branch September 20, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kikobeats @coveralls