Add read-only AL implementation guidance - #188
Draft
Jesper Schulz-Wedde (JesperSchulz) wants to merge 2 commits into
Draft
Jesper Schulz-Wedde (JesperSchulz) wants to merge 2 commits into
Jesper Schulz-Wedde (JesperSchulz) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jesper Schulz-Wedde (JesperSchulz)
added this pull request to stack #189
September 16, 2026 11:31
Jesper Schulz-Wedde (JesperSchulz)
marked this pull request as draft
September 16, 2026 11:46
Contributor
Author
Status: held pending #155 consumer evidenceConverting this PR to draft. The implementation is intentionally preserved, but it should not advance before #155 completes its explicit follow-up sequence:
Only then should we decide whether implementation-time guidance warrants a separate skill/report contract or belongs as a focused mode/input on the existing development-guidance interface. Questions to answer from the pilot before reactivating this PR:
No consumer benefit is claimed by this draft. The current fixtures validate contract mechanics only; they do not establish that this capability improves generated AL beyond plan guidance plus independent final review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and boundary
Adds a focused
al-implementation-guidancecapability above #155 for just-in-time Business Central AL authoring consultation. BCQuality remains read-only: it does not edit source, own workflow or consumed-guidance state, run an implementation/review-fix loop, compile, deploy, stage, commit, or publish. The consuming coding agent owns implementation, tests, retries, final review, and delivery.Input and output contract
The action skill and host-native adapter accept an existing
development-plan, readablerepository, currentimplementation-diff, and currentdecision-context; optionalconsumed-guidanceremains consumer-owned. Missing current diff or decision context returnsnot-applicablerather than inventing state.A strict
implementation-guidance-reportpreserves phase, decision, decision/evidence identifiers, applicability context, affected files/symbols/tokens, and consumer pins. Focused knowledge entries carry exact paths and optional checkout SHA, concreteused-for, faithful normative constraints, opened sample paths, validation considerations, suppressions, and unresolved applicability. Exact consumed path + decision-key + evidence-fingerprint matches are omitted deterministically; materially changed evidence can select the article again.Retrieval and checkpoints
Retrieval is driven by current implementation evidence rather than broad plan domains. The skill recommends explicit, consumer-visible checkpoints for schema/data upgrade, public APIs/events/interfaces, permissions, external effects/job queues/
HttpClient, telemetry/privacy, UI/page background tasks, tests, and bounded agent-initiated consultations. This is hybrid orchestration guidance, not hidden automatic behavior.Evaluation evidence
Adds five production-shaped synthetic fixtures covering an expanded privacy-sensitive schema surface, exact consumed-guidance omission, a no-additional-guidance control, missing current context, and a read-only public-interface checkpoint. The shared scorer now validates both report kinds, exact deduplication, pins/context/reference integrity, and runner-owned pre/post target identity. The implementation regression is chained from the existing Windows/Ubuntu development-guidance CI entrypoint.
Local results:
Limitations
no-knowledgemeans no additional applicable constraints for the exact decision/evidence, not that code is safe, correct, complete, tested, or ready to release. Before/after evidence is not an OS write sandbox and cannot detect a transient reverted write. These fixtures do not run an agent, AL compiler, Business Central tests, deployment, or a production pilot. The documented baseline/plan-only/implementation-only/combined experiment is a recommendation, not a claimed result.Dependency
Depends on #155 and intentionally targets
jesperschulz-ingest-developer-knowledge, notmain.