Skip to content

Update rust-toolchain to 1.95 - #1304

Open
metajack wants to merge 1 commit into
mainfrom
push-vzsqnnnyzrml
Open

Update rust-toolchain to 1.95#1304
metajack wants to merge 1 commit into
mainfrom
push-vzsqnnnyzrml

Conversation

@metajack

Copy link
Copy Markdown
Contributor

Recent reversion of rust-analyzer require 1.94 or newer.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s pinned Rust toolchain version to a newer stable release to satisfy a newer rust-analyzer minimum version requirement.

Changes:

  • Bump rust-toolchain.toml from Rust 1.92 to 1.97.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rust-toolchain.toml Outdated
@metajack
metajack force-pushed the push-vzsqnnnyzrml branch from acf436e to d883030 Compare July 31, 2026 17:09
Copilot AI review requested due to automatic review settings July 31, 2026 17:09
@metajack metajack changed the title Update rust-toolchain to 1.97.1 Update rust-toolchain to 1.95 Jul 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 31, 2026 17:31
@metajack
metajack force-pushed the push-vzsqnnnyzrml branch from d883030 to d1cb33a Compare July 31, 2026 17:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Suppressed comments (1)

diskann-wide/src/test_utils/distribution.rs:98

  • This macro still uses type-relative paths like <$T>::SIGN_MASK / <$T>::EXPONENT_MASK / <$T>::EXPONENT_ZERO / <$T>::MANTISSA_MASK later in sample(). With Rust 1.95 these can become ambiguous for half::f16 (inherent consts vs Layout), and CI treats warnings as errors. Disambiguate the remaining uses to Layout as well.
                    (<$T as Layout>::MANTISSA_MASK, true, false)
                } else {
                    // Generate zero.
                    (0, true, true)
                };

Comment thread diskann-wide/src/test_utils/distribution.rs
Copilot AI review requested due to automatic review settings July 31, 2026 17:56
@metajack
metajack force-pushed the push-vzsqnnnyzrml branch 2 times, most recently from 4e11094 to afa5510 Compare July 31, 2026 17:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

@metajack
metajack force-pushed the push-vzsqnnnyzrml branch from afa5510 to eafb3d3 Compare July 31, 2026 23:29
Copilot AI review requested due to automatic review settings July 31, 2026 23:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

@metajack
metajack enabled auto-merge (squash) July 31, 2026 23:44
@codecov-commenter

codecov-commenter commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.46%. Comparing base (b7cf3b0) to head (eafb3d3).

Files with missing lines Patch % Lines
diskann-benchmark/src/index/search/knn.rs 66.66% 1 Missing ⚠️
diskann-benchmark/src/index/search/range.rs 0.00% 1 Missing ⚠️
diskann-garnet/src/provider.rs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
+ Coverage   90.68%   91.46%   +0.77%     
==========================================
  Files         515      516       +1     
  Lines       99230    98200    -1030     
==========================================
- Hits        89987    89817     -170     
+ Misses       9243     8383     -860     
Flag Coverage Δ
miri 91.46% <85.71%> (+0.77%) ⬆️
unittests 91.13% <85.71%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iskann-benchmark-runner/src/internal/regression.rs 98.11% <100.00%> (+0.46%) ⬆️
diskann-disk/src/search/provider/disk_provider.rs 95.76% <100.00%> (+1.75%) ⬆️
...kann-disk/src/search/provider/disk_sector_graph.rs 97.34% <100.00%> (+0.36%) ⬆️
diskann-inmem/src/provider.rs 88.92% <100.00%> (+0.15%) ⬆️
diskann-wide/src/test_utils/distribution.rs 100.00% <100.00%> (ø)
diskann-wide/src/test_utils/dot_product.rs 100.00% <100.00%> (+2.56%) ⬆️
diskann-benchmark/src/index/search/knn.rs 78.00% <66.66%> (ø)
diskann-benchmark/src/index/search/range.rs 0.00% <0.00%> (ø)
diskann-garnet/src/provider.rs 81.40% <50.00%> (+0.28%) ⬆️

... and 210 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hildebrandmw
hildebrandmw disabled auto-merge July 31, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants