Repository navigation
Add rollbackVersion option and default releaseTrain to stable in Ev2 SDP pipelines #1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,11 +26,28 @@ parameters: | |
| - name: 'releaseTrain' | ||
| displayName: 'Release Train' | ||
| type: string | ||
| default: 'preview' | ||
| default: 'stable' | ||
| values: | ||
| - preview | ||
| - stable | ||
|
|
||
| # Optional. 'none' (the default) means NO rollback: the run is a normal | ||
| # roll-forward to the version selected above. | ||
| # | ||
| # Azure DevOps renders a parameter whose default is an empty string as a | ||
| # REQUIRED field, so we default to the 'none' sentinel and strip it back to an | ||
| # empty string in the ConfigurationOverrides below. The central artifacts | ||
| # register.sh writes an empty rollbackVersion as JSON null, i.e. no rollback. | ||
| # | ||
| # HOW TO ROLL BACK: RollbackVersion is stored on the version document that is | ||
| # being registered (the rollout PATCHes .../versions/<version>), so set BOTH: | ||
| # overrideExtensionVersion -> the bad version currently in the field (roll back FROM) | ||
| # rollbackVersion -> the last known-good version (roll back TO) | ||
| - name: 'rollbackVersion' | ||
| displayName: 'Rollback version ("none" = roll forward)' | ||
| type: string | ||
| default: 'none' | ||
|
|
||
| - name: 'rolloutType' | ||
| displayName: 'SDP rollout type' | ||
| type: string | ||
|
|
@@ -100,6 +117,10 @@ variables: | |
| # files (now removed). MSI ARM IDs below must be the cloud-specific identity | ||
| # registered in the extension type registration document (msiClientIds field). | ||
| # See: https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/202225/Extension-Type-Registration | ||
| # | ||
| # rollbackVersion is resolved at compile time: the 'none' sentinel collapses to | ||
| # an empty string, which the central artifacts register.sh writes as JSON null | ||
| # (no rollback). See the rollbackVersion parameter above. | ||
|
|
||
| - name: ProdConfigurationOverrides | ||
| value: | | ||
|
|
@@ -112,6 +133,7 @@ variables: | |
| "userAssignedIdentity": "/subscriptions/30c56c3a-54da-46ea-b004-06eb33432687/resourceGroups/containerinsightsprod/providers/Microsoft.ManagedIdentity/userAssignedIdentities/ev2-agent-release", | ||
| "version": "$(extensionVersionValue)", | ||
| "releaseTrain": "${{ parameters.releaseTrain }}", | ||
| "rollbackVersion": "${{ replace(parameters.rollbackVersion, 'none', '') }}", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| "kustoGatingWaitDuration": "PT1H" | ||
| } | ||
| } | ||
|
|
@@ -127,6 +149,7 @@ variables: | |
| "userAssignedIdentity": "/subscriptions/e4f0f588-48fc-43c1-86b3-2861f1ddaa9d/resourcegroups/container-insights-extension-fairfax/providers/Microsoft.ManagedIdentity/userAssignedIdentities/extension-rollout-identity-ContainerInsights", | ||
| "version": "$(extensionVersionValue)", | ||
| "releaseTrain": "${{ parameters.releaseTrain }}", | ||
| "rollbackVersion": "${{ replace(parameters.rollbackVersion, 'none', '') }}", | ||
| "kustoGatingWaitDuration": "PT1H" | ||
| } | ||
| } | ||
|
|
@@ -143,6 +166,7 @@ variables: | |
| "userAssignedIdentity": "/subscriptions/fdbe2580-1746-4bb7-ae1a-da7ada55880b/resourcegroups/container-insights-extension-mooncake/providers/Microsoft.ManagedIdentity/userAssignedIdentities/Extension-insights-mooncake", | ||
| "version": "$(extensionVersionValue)", | ||
| "releaseTrain": "${{ parameters.releaseTrain }}", | ||
| "rollbackVersion": "${{ replace(parameters.rollbackVersion, 'none', '') }}", | ||
| "kustoGatingWaitDuration": "PT1H" | ||
| } | ||
| } | ||
|
|
@@ -159,6 +183,7 @@ variables: | |
| "userAssignedIdentity": "/subscriptions/f8272cc8-8c5a-438c-ad5c-21264c697c53/resourcegroups/ContainerInsights-AI/providers/Microsoft.ManagedIdentity/userAssignedIdentities/ContainerInsights-MI", | ||
| "version": "$(extensionVersionValue)", | ||
| "releaseTrain": "${{ parameters.releaseTrain }}", | ||
| "rollbackVersion": "${{ replace(parameters.rollbackVersion, 'none', '') }}", | ||
| "kustoGatingWaitDuration": "PT1H" | ||
| } | ||
| } | ||
|
|
@@ -175,6 +200,7 @@ variables: | |
| "userAssignedIdentity": "/subscriptions/3be87dbe-53e1-410a-b8b7-a0d8fa86a9e9/resourcegroups/ContainerInsights-AI/providers/Microsoft.ManagedIdentity/userAssignedIdentities/ContainerInsights-MI", | ||
| "version": "$(extensionVersionValue)", | ||
| "releaseTrain": "${{ parameters.releaseTrain }}", | ||
| "rollbackVersion": "${{ replace(parameters.rollbackVersion, 'none', '') }}", | ||
| "kustoGatingWaitDuration": "PT1H" | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the rollback instructions from extension team: https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/1149646/Extension-Type-Registration?anchor=rolling-back-a-released-version