Repository navigation
Give patch capture and grading staging 600 s instead of 120 s - #40
Open
Edward Glöckner (EdwardGlockner) wants to merge 1 commit into
Open
Edward Glöckner (EdwardGlockner) wants to merge 1 commit into
Edward Glöckner (EdwardGlockner) wants to merge 1 commit into
Conversation
get_patch() and the pre-verifier `git add -A` run over the whole worktree after the agent has finished, but use the 120 s default command timeout. On a large repository or a busy node this can time out, which raises out of the attempt and discards the completed agent run; the task is then replayed from scratch. We hit this running SWE-bench Verified locally (django__django-15916: a finished 21-minute run lost to the 120 s timeout and re-run). Use a 600 s timeout for both.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_patch()and the pre-verifiergit add -Astage the whole worktree after the agent has finished but use the 120 s default command timeout. When that times out (large repo, busy node, many untracked files), the exception ends the attempt and the completed agent run is discarded and replayed. We hit this on SWE-bench Verifieddjango__django-15916: a finished 21-minute run was lost to the 120 s timeout and re-run from scratch. This raises both to 600 s (module constant_GIT_STAGING_TIMEOUT) and asserts it intest_get_patch_resets_index_after_capture.