Skip to content

Bump xunit.v3 from 3.2.2 to 4.0.0 #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Bump xunit.v3 from 3.2.2 to 4.0.0 #3055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
db00c66
Bump xunit.v3 from 3.2.2 to 4.0.0
dependabot[bot] Aug 24, 2026
20ef98d
test(mtp): migrate xunit projects to MTP
Copilot Aug 25, 2026
d44be15
ci(azure): run xunit MTP test apps directly
Copilot Aug 25, 2026
5406f82
ci(azure): centralize test target framework
Copilot Aug 25, 2026
9d749ca
ci(azure): define test target framework variable
Copilot Aug 25, 2026
a88a909
ci(azure): collect all mtp test results
Copilot Aug 25, 2026
1a8572f
ci(azure): discover mtp test executables
Copilot Aug 25, 2026
7cc75c4
ci(azure): discover xunit mtp test apps
Copilot Aug 25, 2026
94d87e0
ci(azure): document xunit mtp marker
Copilot Aug 25, 2026
399bcfd
ci(azure): relax xunit mtp marker
Copilot Aug 25, 2026
6719deb
ci(azure): format mtp test invocation
Copilot Aug 25, 2026
3145024
ci(azure): preserve mtp runner exit code
Copilot Aug 25, 2026
fb02179
ci(azure): log mtp test app failures
Copilot Aug 25, 2026
f57d73c
ci(azure): document mtp output path assumption
Copilot Aug 25, 2026
e15916b
ci(azure): log mtp test candidates
Copilot Aug 25, 2026
dfcc2dc
ci(azure): validate mtp output layout
Copilot Aug 25, 2026
530e63b
ci(azure): simplify mtp test execution
Copilot Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .azure-pipelines/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,24 @@ extends:
arguments: '--configuration $(BuildConfiguration) --no-incremental'

# Run the Unit test
- task: DotNetCoreCLI@2
- pwsh: |
dotnet test "$(Build.SourcesDirectory)\Microsoft.OpenApi.slnx" `
--configuration $(BuildConfiguration) `
--no-build `
-- `
--report-xunit-trx `
--results-directory "$(Agent.TempDirectory)\TestResults" `
--minimum-expected-tests 1
displayName: 'test'

- task: PublishTestResults@2
displayName: 'Publish test results'
condition: succeededOrFailed()
inputs:
command: test
projects: '$(Build.SourcesDirectory)\Microsoft.OpenApi.slnx'
arguments: '--configuration $(BuildConfiguration) --no-build'
testResultsFormat: VSTest
testResultsFiles: '$(Agent.TempDirectory)\TestResults\*.trx'
failTaskOnMissingResultsFile: true
failTaskOnFailedTests: true

- task: EsrpCodeSigning@6
displayName: 'ESRP CodeSigning binaries'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
id: run_unit_tests
shell: pwsh
run: |
dotnet test Microsoft.OpenApi.slnx -c Release --no-build -v n --collect:"XPlat Code Coverage"
dotnet test --solution Microsoft.OpenApi.slnx -c Release -v n --coverlet --coverlet-output-format cobertura

- name: Install report generator
shell: pwsh
Expand All @@ -55,7 +55,7 @@ jobs:
- name: Generate coverage report
shell: pwsh
run: |
reportgenerator -reports:**/coverage.cobertura.xml -targetdir:./reports/coverage -reporttypes:"Html;MarkdownSummaryGithub;Cobertura"
reportgenerator -reports:**/coverage.cobertura*.xml -targetdir:./reports/coverage -reporttypes:"Html;MarkdownSummaryGithub;Cobertura"

- name: Add coverage to job summary
shell: bash
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/sonarcloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,10 @@ jobs:
- name: Build and analyze
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
CollectCoverage: true
CoverletOutputFormat: 'opencover' # https://github.com/microsoft/vstest/issues/4014#issuecomment-1307913682
shell: pwsh
run: |
dotnet tool run dotnet-sonarscanner begin /k:"microsoft_OpenAPI.NET" /o:"microsoft" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.opencover.reportsPaths="test/**/coverage.opencover.xml"
dotnet tool run dotnet-sonarscanner begin /k:"microsoft_OpenAPI.NET" /o:"microsoft" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.opencover.reportsPaths="**/coverage.opencover*.xml"
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
dotnet workload restore
dotnet build
dotnet test Microsoft.OpenApi.slnx --no-build --verbosity normal /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
dotnet test --solution Microsoft.OpenApi.slnx --verbosity normal --coverlet --coverlet-output-format opencover
dotnet tool run dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}"
3 changes: 3 additions & 0 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"sdk": {
"version": "10.0.400"
},
"test": {
"runner": "Microsoft.Testing.Platform"
}
}
7 changes: 3 additions & 4 deletions test/Microsoft.OpenApi.Hidi.Tests/Microsoft.OpenApi.Hidi.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,14 @@
<NoWarn>CA2007</NoWarn>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\src\Microsoft.OpenApi.snk</AssemblyOriginatorKeyFile>
<UseMicrosoftTestingPlatformRunner>true</UseMicrosoftTestingPlatformRunner>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="coverlet.msbuild" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="coverlet.MTP" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="xunit.v3" Version="3.2.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" PrivateAssets="all" />
<PackageReference Include="coverlet.collector" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="xunit.v3" Version="4.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
7 changes: 3 additions & 4 deletions test/Microsoft.OpenApi.Readers.Tests/Microsoft.OpenApi.Readers.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<GeneratePackageOnBuild>false</GeneratePackageOnBuild>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\src\Microsoft.OpenApi.snk</AssemblyOriginatorKeyFile>
<UseMicrosoftTestingPlatformRunner>true</UseMicrosoftTestingPlatformRunner>
</PropertyGroup>
<ItemGroup>
<EmbeddedResource Include="**\*.yaml" Exclude="**\bin\**;**\obj\**">
Expand All @@ -15,12 +16,10 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="coverlet.collector" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="coverlet.msbuild" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="coverlet.MTP" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="FluentAssertions" Version="7.2.2" />
<PackageReference Include="xunit.v3" Version="3.2.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" PrivateAssets="all" />
<PackageReference Include="xunit.v3" Version="4.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
7 changes: 3 additions & 4 deletions test/Microsoft.OpenApi.Tests/Microsoft.OpenApi.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,16 @@
<SignAssembly>true</SignAssembly>
<OutputType>Library</OutputType>
<AssemblyOriginatorKeyFile>..\..\src\Microsoft.OpenApi.snk</AssemblyOriginatorKeyFile>
<UseMicrosoftTestingPlatformRunner>true</UseMicrosoftTestingPlatformRunner>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="coverlet.collector" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="coverlet.msbuild" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="coverlet.MTP" Version="10.0.1" PrivateAssets="all" />
<PackageReference Include="FluentAssertions" Version="7.2.2" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="Verify.XunitV3" Version="31.28.0" />
<PackageReference Include="xunit.v3" Version="3.2.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5" PrivateAssets="all" />
<PackageReference Include="xunit.v3" Version="4.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading