Repository navigation
Update samples data for Aspire 13.6 - #1818
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
David Pine (IEvangelist)
enabled auto-merge (squash)
October 2, 2026 16:10
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
Refreshes the samples gallery data to align with Aspire 13.6, adds Java tagging support, and improves sample card rendering by stripping Markdown tables from plain-text descriptions.
Changes:
- Regenerated
samples.json(new samples, updated screenshots/metadata, Aspire 13.6 references). - Added a
javatag label and a Java detection rule in the samples update script. - Updated
sampleDescriptionTextto strip Markdown table rows and added a unit test for it.
| File | Description |
|---|---|
| src/frontend/tests/unit/custom-components.vitest.test.ts | Adds a unit test ensuring Markdown tables are removed from card/preview plain-text sample descriptions. |
| src/frontend/src/utils/samples.ts | Updates sampleDescriptionText to remove Markdown table rows before other Markdown-to-text rewrites. |
| src/frontend/src/utils/sample-tags.ts | Adds a display label for the new java tag. |
| src/frontend/src/data/samples.json | Updates sample dataset for Aspire 13.6, adds spring-petclinic and terminals, refreshes readmes/screenshots metadata. |
| src/frontend/scripts/update-samples.ts | Adds tag inference rule for Java ecosystem signals (Spring Boot/Quarkus/Maven/Gradle/etc.). |
| .agents/skills/update-samples/SKILL.md | Documents the new java tag inference rule in the skill doc. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
- Make the Java tag pattern case-insensitive to match the rest of the rules. - Rewrite table stripping to remove whole table blocks (header, separator, body rows), tolerating missing leading/trailing pipes and alignment markers like :---: instead of only lines with both a leading and trailing pipe. - Add tests for table variants without leading/trailing pipes and with alignment markers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Eric Erhardt (eerhardt)
approved these changes
Oct 5, 2026
Adding the java tag to spring-petclinic introduced a 6th entry in sampleLanguageOptions (derived from all samples, not just the featured six), which the hub page's language filter now exposes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes the samples data from
microsoft/aspire-samples, which upgraded to Aspire 13.6.samples.jsonwithpnpm update:samples. AppHost code and descriptions now reference 13.6, and the newspring-petclinicandterminalssamples are added (29 samples total). Updated and new light/dark screenshots are included; existing images are kept.javatag rule toupdate-samples.ts(Java, Spring Boot, Quarkus, Maven, Gradle,mvnw) and aJavatag label.spring-petclinicnow appears under the Java language filter in the samples gallery and resource directory. No other samples changed.sampleDescriptionTextnow strips Markdown table rows. Previously theterminalscard, and the expanded "Read more" text onaspire-with-javascript, rendered raw table Markdown.update-samplesskill's tag table.Third-party links and affiliations
None
Validation
pnpm exec vitest run tests/unit/custom-components.vitest.test.ts tests/unit/dev-resource-catalog.vitest.test.ts: passed (113 tests), including a new test for table stripping.pnpm dev:/reference/samples/,/reference/samples/spring-petclinic/and/reference/samples/terminals/return 200, the Java badge renders, and the terminals card no longer shows raw table Markdown.