Bound layer decompression during staging and extraction - #117
Draft
Bruno Borges (brunoborges) with Copilot wants to merge 3 commits into
Draft
Bruno Borges (brunoborges) with Copilot wants to merge 3 commits into
Bruno Borges (brunoborges) with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix decompression size cap in layer extraction
Bound layer decompression during staging and extraction
Sep 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three copy loops moved layer bytes with unbounded
io.Copy, each suppressed from gosec with a//nolint:gosec // trusted layer contentcomment. Layer content is publisher-supplied and only digest-verified, so a gzip or sparse-tar bomb inside a legitimate image could decompress without limit into the shared staging root (/tmp/brewlet-runnable/...) or the bundle's classpath dirs.Changes
core/internal/artifact/blobs.goMaxLayerDecompressedBytes(8 GiB ceiling, lowerable by tests) andCopyBounded(dst, src, limit), which fails loudly once the limit is breached instead of expanding a bomb.gunzipToFilecopies through the cap and removes the half-written layer on breach, so a failed stage leaves nothing behind.extractGzTarspends one budget across all entries (including the trailing gzip drain at EOF), so many small entries cannot bypass a per-entry cap.core/internal/runtime/launch.goextractTarusesartifact.CopyBoundedwith the same per-tar budget.//nolint:gosecsuppressions are removed — the G110 finding they hid is now addressed.The cap is an availability bound, not a payload constraint; per-layer limits could later ride the manifest's declared sizes where available.