Repository navigation
fix: Upgrade Node.js version - #720
Closed
KanchanN-Microsoft wants to merge 1 commit into
Closed
KanchanN-Microsoft wants to merge 1 commit into
KanchanN-Microsoft wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Build and deployment compatibility for the major runtime upgrade remains unvalidated, and frontend CI remains disabled.
No open issues 🎉
What changed in this PR
This PR moves the web application, workflow image, and development containers to Node.js 24 to align runtime requirements across the project.
Changes:
- Updates container images and Node.js installation settings to Node.js 24.
- Raises the web application's Node.js requirement to
>=24.22.1 <25. - Updates the commented-out frontend CI configuration; active CI behavior is unchanged.
| File | Description |
|---|---|
src/ContentProcessorWorkflow/Dockerfile |
Pins the Node.js download to 24.22.1. |
src/ContentProcessorWorkflow/.devcontainer/devcontainer.json |
Selects Node.js 24 for workflow development. |
src/ContentProcessorWeb/package.json |
Requires Node.js >=24.22.1 <25. |
src/ContentProcessorWeb/Dockerfile |
Uses the Node.js 24.22.1 Bookworm build image. |
src/ContentProcessorWeb/.devcontainer/Dockerfile |
Switches to the current TypeScript devcontainer image namespace and Node.js 24 variant. |
src/ContentProcessorWeb/.devcontainer/devcontainer.json |
Passes the 24-bookworm build variant. |
src/ContentProcessorWeb/.devcontainer/base.Dockerfile |
Switches to the current JavaScript devcontainer image namespace and Node.js 24 variant. |
.github/workflows/test.yml |
Updates only the commented-out Node.js setup version. |
.devcontainer/Dockerfile |
Installs Node.js from the NodeSource 24 channel. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request upgrades the development environment and build configurations across the project to use Node.js 24 (from Node.js 20 or 22). This ensures consistency, compatibility with newer dependencies, and alignment with the latest Node.js LTS releases.
Node.js Version Upgrades:
.devcontainerand main build files to use Node.js 24 images and versions, replacing previous Node.js 20/22 references (.devcontainer/Dockerfile,src/ContentProcessorWeb/.devcontainer/Dockerfile,src/ContentProcessorWeb/.devcontainer/base.Dockerfile,src/ContentProcessorWeb/Dockerfile,src/ContentProcessorWorkflow/Dockerfile). [1] [2] [3] [4] [5]package.jsonto require Node.js >=24.22.1 <25.Development Container and Workflow Updates:
VARIANT=24-bookworm,"version": "24"), ensuring local development matches the new Node.js version. [1] [2]These changes collectively ensure that all development, CI, and deployment environments are standardized on Node.js 24.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information