Skip to content

fix: Upgrade Node.js version - #720

Closed
KanchanN-Microsoft wants to merge 1 commit into
devfrom
psl-upgrade-nodejs
Closed

KanchanN-Microsoft wants to merge 1 commit into
devfrom
psl-upgrade-nodejs

Conversation

@KanchanN-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request upgrades the development environment and build configurations across the project to use Node.js 24 (from Node.js 20 or 22). This ensures consistency, compatibility with newer dependencies, and alignment with the latest Node.js LTS releases.

Node.js Version Upgrades:

  • Updated all Dockerfiles in .devcontainer and main build files to use Node.js 24 images and versions, replacing previous Node.js 20/22 references (.devcontainer/Dockerfile, src/ContentProcessorWeb/.devcontainer/Dockerfile, src/ContentProcessorWeb/.devcontainer/base.Dockerfile, src/ContentProcessorWeb/Dockerfile, src/ContentProcessorWorkflow/Dockerfile). [1] [2] [3] [4] [5]
  • Updated Node.js version constraints in package.json to require Node.js >=24.22.1 <25.

Development Container and Workflow Updates:

  • Changed devcontainer build arguments and configuration to use Node.js 24 (VARIANT=24-bookworm, "version": "24"), ensuring local development matches the new Node.js version. [1] [2]
  • Updated GitHub Actions workflow to reference Node.js 24 for CI/CD testing.

These changes collectively ensure that all development, CI, and deployment environments are standardized on Node.js 24.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL122516786% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
244 0 💤 0 ❌ 0 🔥 3.077s ⏱️

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Build and deployment compatibility for the major runtime upgrade remains unvalidated, and frontend CI remains disabled.

No open issues 🎉

What changed in this PR

This PR moves the web application, workflow image, and development containers to Node.js 24 to align runtime requirements across the project.

Changes:

  • Updates container images and Node.js installation settings to Node.js 24.
  • Raises the web application's Node.js requirement to >=24.22.1 <25.
  • Updates the commented-out frontend CI configuration; active CI behavior is unchanged.
File Description
src/​ContentProcessorWorkflow/​Dockerfile Pins the Node.js download to 24.22.1.
src/​ContentProcessorWorkflow/​.devcontainer/​devcontainer.json Selects Node.js 24 for workflow development.
src/​ContentProcessorWeb/​package.json Requires Node.js >=24.22.1 <25.
src/​ContentProcessorWeb/​Dockerfile Uses the Node.js 24.22.1 Bookworm build image.
src/​ContentProcessorWeb/​.devcontainer/​Dockerfile Switches to the current TypeScript devcontainer image namespace and Node.js 24 variant.
src/​ContentProcessorWeb/​.devcontainer/​devcontainer.json Passes the 24-bookworm build variant.
src/​ContentProcessorWeb/​.devcontainer/​base.Dockerfile Switches to the current JavaScript devcontainer image namespace and Node.js 24 variant.
.github/​workflows/​test.yml Updates only the commented-out Node.js setup version.
.devcontainer/​Dockerfile Installs Node.js from the NodeSource 24 channel.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants