Pin MCP SDK to v1 and fix stale prompt instructions - #123
Open
Brandon Werner (brandwe) wants to merge 3 commits into
Open
Brandon Werner (brandwe) wants to merge 3 commits into
Brandon Werner (brandwe) wants to merge 3 commits into
Conversation
Prompt audit against Claude Opus 5.5. Fixes instructions that contradicted each other or pointed at the wrong tool: - read_interactions no longer tells the model to sweep history before every send (the body prompt forbids that) - wait_for_sponsor_dm no longer loops on itself or claims Claude Code lacks channel push - read_file / files.py stop referencing nonexistent read_workbook_range - SessionStart hook points at the files the require_body_prompt gate actually accepts - drop the PostToolUse reminder recommending watch_teams_replies - identity-and-tools: remove stale workflow + shadow tool list, fix memory routing, trim Python hygiene to repo deps - channel-discipline: drop "when in doubt, spawn" and dangling superpowers skill reference - AGENTS.md: correct body-vs-persona prompt line, trim Active Work to pointers - refresh-persona skill reloads from persona-sati, not local files - send_teams_message/create_chat: remove examples that contradict always-HTML; flesh out Agent 365 tool descriptions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three commits:
11b2b32fix: pin MCP Python SDK to v1mcpinpyproject.toml, with a constraint test intests/test_dependency_constraints.py.3fd0eb9test: align suite with canonical agent instructionstest_prompt_doctrine.py(and one script test) to follow the instruction consolidation inf878cea:CLAUDE.mdnow delegates toAGENTS.md, and.github/copilot-instructions.mdis gone.8a67b89fix(prompts): remove contradictory and stale prompt instructionsComes from a prompt audit against Claude Opus 5.5. Most of it fixes instructions that contradicted each other or sent the model to the wrong tool:
read_interactionstold the model to scan history before every send, which the body prompt forbids.wait_for_sponsor_dmtold the model to loop on itself, which makes it wait twice now thatsend_teams_messagewaits on its own. It also said Claude Code has no channel push, which is wrong.read_fileandtools/files.pypointed toread_workbook_range, which doesn't exist.require_body_promptgate doesn't accept that file. The hook now namesprompts/agent_system.mdand theanatomy/files.watch_teams_repliesreminder after every send.identity-and-tools.md:AGENTS.mdchannel-discipline.md: dropped "when in doubt, spawn" and the reference to the missingsuperpowers:skill.AGENTS.md: corrected the line that contradicted body-first prompt loading, and cut "Active Work" down to pointers todocs/project/status.md.refresh-personaskill: now reloads from persona-sati instead of the local memory dir.send_teams_message/create_chat: removed examples that contradicted always-HTML. The six Agent 365 tools now have full descriptions.security.mdwas not changed.Test plan
pytest -v && ruff check .: 1688 passed, 1 skipped, lint cleanread_interactionswording🤖 Generated with Claude Code