Fix flaky SQL statistics test - #5769
Open
apurvabhaleMS wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5769 +/- ##
==========================================
+ Coverage 78.79% 78.81% +0.02%
==========================================
Files 1020 1020
Lines 37783 37783
Branches 5754 5754
==========================================
+ Hits 29772 29780 +8
+ Misses 6594 6582 -12
- Partials 1417 1421 +4 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an intermittent failure in
GivenMissingTrueSearchForPatientByGender_NotExistsStatsAreCreated.The SQL search statistics cache is process-wide and may already contain valid
individual-genderstatistics for non-Patient resource types created by other test classes. The test now snapshots the cache before executing the Patientgender:missing=truesearch and scopes its negative assertion to newly added statistics. The positive assertion still verifies that the expected Patient statistic exists after the search.Related issues
Addresses AB205695
Testing
Result: 1 passed, 0 failed.
FHIR Team Checklist
Semver Change (docs)
Skip