fix(site): reset scroll position when navigating between docs - #82
Open
yelper wants to merge 2 commits into
Open
fix(site): reset scroll position when navigating between docs#82yelper wants to merge 2 commits into
yelper wants to merge 2 commits into
Conversation
The documentation page uses a custom scroll container, so the browser's default scroll-to-top on navigation doesn't apply. Add a useEffect that scrolls the container to the top whenever the active doc slug changes, unless a heading anchor is pending. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When navigating between pages in the documentation site, the scroll position is not reset to top as in normal page navigation.
This PR identifies hash changes that actually resulted in a different page content being loaded and explicitly sets the scrollPosition of the content to the top of the document.