DPDK: deprecate run_testpmd_concurrent for hotplug tests#4604
Draft
mcgov wants to merge 3 commits into
Draft
Conversation
Comment on lines
+224
to
+229
| # let it run for a bit | ||
| sleep(10) | ||
|
|
||
| # switch_sriov(... wait=True) has become really expensive, | ||
| # and it can easily timeout if things aren't perfect. | ||
| # So: we'll avoid all of that and just start processes and wait for output. |
Gets rid of old abstraction that didn't allow direct monitoring of testpmd processes. It is replaced with new functions specifically for each version of the test. We are violating the DRY ethos here in favor of readability and maintaining direct control over the processes. This allows implementing the hotplug tests in a cleaner way, which also ends up being faster and more reliable in practice.
mcgov
force-pushed
the
mcgov/hotplug-rework
branch
from
July 17, 2026 18:34
23b9284 to
85b4327
Compare
Comment on lines
+236
to
+238
| processes[collect_from].wait_output( | ||
| "HN_DRIVER: netvsc_hotadd_callback(): Device notification type=1" | ||
| ) |
Comment on lines
+224
to
+226
| # let it run for a bit | ||
| sleep(10) | ||
|
|
Comment on lines
+240
to
+242
| # let it run for a bit | ||
| sleep(10) | ||
|
|
Comment on lines
+253
to
+255
| # let it run for a bit | ||
| sleep(30) | ||
| # kill testpmd and process the output |
Comment on lines
666
to
671
| return ( | ||
| f"{self._testpmd_install_path} {core_list} " | ||
| f"{nic_includes} {debug_logging} -- --forward-mode={mode} " | ||
| f"-a --stats-period 2 --nb-cores={forwarding_cores} {extra_args} " | ||
| f"-a --stats-period {stats_period} --nb-cores={forwarding_cores}" | ||
| f" {extra_args} --record-burst-stats" | ||
| ) |
| f"into status [{enable}]" | ||
| ).is_equal_to(enable) | ||
|
|
||
| @retry(HttpResponseError, tries=3, delay=30) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gets rid of old abstraction that didn't allow direct monitoring of testpmd processes.
It is replaced with new functions specifically for each version of the test. We are violating the DRY ethos here in favor of readability and maintaining direct control over the processes.
This allows implementing the hotplug tests in a cleaner way, which also ends up being faster and more reliable in practice.
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
verify_dpdk_testpmd_hotplug_sender_netvsc_pmd|verify_dpdk_testpmd_hotplug_receiver_netvsc_pmd|verify_dpdk_l3fwd_ntttcp_tcp_hotplug
Impacted LISA Features:
Dpdk
Tested Azure Marketplace Images:
Canonical:ubuntu-24_04-lts:server:latest
Test Results