Deduplicate lsif npm identifiers - #66
Open
Eric Fritz (efritz) wants to merge 1 commit into
Open
Conversation
|
|
Contributor
|
Dirk Bäumer (@dbaeumer) Jullyana Ramos (@jumattos) Could you take a look? |
Author
|
Any chance of looking at this? |
Author
|
Dirk Bäumer (@dbaeumer) any chance you could look at this? |
Eric Fritz (efritz)
force-pushed
the
deduplicate-lsif-npm-identifiers
branch
from
November 14, 2019 15:02
c79d693 to
2706d1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of lsif-npm can contain vertices and edges with duplicated IDs. This PR ensures that a global integer ID generator is created to stop the current behavior of resetting the counter to
MAX_SAFE_INTEGERon each construction (one for the import linker, one for the export linker, and one each time an int-id moniker is encountered after a uuid-id moniker).