Fix LXC schema drift guard - #1323
Closed
Huzaifa Danish (huzaifa-d) wants to merge 1 commit into
Closed
Huzaifa Danish (huzaifa-d) wants to merge 1 commit into
Huzaifa Danish (huzaifa-d) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Huzaifa Danish (huzaifa-d)
September 29, 2026 16:59
View session
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Huzaifa Danish (huzaifa-d)
force-pushed
the
user/modanish/fix-lxc-schema-drift
branch
from
September 29, 2026 17:00
7570fb5 to
ba5b649
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The Hyperlight fallback can miss denied dangling symlinks, and the security-sensitive work is outside the documented PR scope.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the LXC v0.8 fixture drift guard, while also introducing an undocumented Hyperlight policy change.
Changes:
- Ignores version-derived
$schemametadata during fixture comparison. - Adds cross-platform Hyperlight denied-path overlap detection and tests.
- Introduces a non-Windows dangling-symlink enforcement gap.
| File | Description |
|---|---|
tests/scripts/run_lxc_network_legacy_v08_compat_test.sh |
Excludes $schema from fixture drift checks. |
src/backends/hyperlight/common/src/lib.rs |
Expands denied-path overlap validation and coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Huzaifa Danish (huzaifa-d)
marked this pull request as ready for review
September 29, 2026 17:02
Copilot started reviewing on behalf of
Huzaifa Danish (huzaifa-d)
September 29, 2026 17:03
View session
Contributor
|
Resolved in #1316 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore version-derived
$schemametadata in the LXC legacy v0.8 fixture drift check.Microsoft Reviewers: Open in CodeFlow