Repository navigation
Align Node v1 conformance with the published 1.0 contract - #1479
Merged
Merged
Conversation
This PR aligns Node v1 one-shot type conformance with the published 1.0.0 contract emitted by the SDK. It removes the obsolete NetworkConfig type and Linux helper that mutated retired network fields. Runtime rejection of unsupported legacy policy remains intact. Details * Compare public v1 authoring types with generated published 1.0 wire types. * Use directional networking throughout the internal request mapping. * Remove obsolete legacy-network mutation and update codegen documentation. Tests * `npm run typecheck --prefix sdk\node` passed, including packed integration. * `npm test --prefix sdk\node` passed: 444 passed, 21 skipped. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 735d3e0b-8eff-4395-9f2c-dff9b0f86b74 Generated-with: gpt-6-sol
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently align Node V1 with the registered 1.0.0 contract while preserving runtime rejection of retired fields.
0 open findings
What changed in this PR
Aligns Node V1 conformance and internal mapping with the published 1.0.0 contract.
Changes:
- Targets generated V1.0 wire types and validates the SDK contract version.
- Removes retired legacy network types and mutation logic.
- Updates schema-codegen documentation.
| File | Description |
|---|---|
sdk/node/tests/unit/wire-conformance.test.ts |
Uses the published V1.0 oracle. |
sdk/node/src/v1/types.ts |
Restricts networking to directional policy. |
sdk/node/src/v1/container.ts |
Removes obsolete Linux network mutation. |
sdk/node/src/helper.ts |
Deletes the legacy network helper. |
sdk/node/src/bindings/one-shot.ts |
Validates directional network types. |
docs/development/build-and-test/schema-codegen.md |
Documents the V1.0 conformance oracle. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Gudge (MGudgin)
added this pull request to stack #1480
October 13, 2026 16:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Node v1 wire-conformance oracle to compare against the
published 1.0.0 contract rather than the mutable 1.1 development contract.
It removes a legacy network type and helper that referenced retired fields
while retaining runtime rejection of unsupported policy.
Details
legacy-network mutation.
Tests
npm run typecheck --prefix sdk\node— passed (SDK build, unit typecheck,and packed-package integration compilation).
npm test --prefix sdk\node— passed (444 passed, 21 skipped).Microsoft Reviewers: Open in CodeFlow