Skip to content

Remove the Electron Playground - #1546

Merged
Gudge (MGudgin) merged 1 commit into
mainfrom
user/gudge/remove_playground
Oct 21, 2026
Merged

Gudge (MGudgin) merged 1 commit into
mainfrom
user/gudge/remove_playground

Conversation

@MGudgin

@MGudgin Gudge (MGudgin) commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

This PR deletes tests/playground, the Electron app for trying MXC policies interactively. Since #1355 it has called Node SDK entry points that no longer exist: the now-empty @microsoft/mxc-sdk root export (getPlatformSupport), spawnSandbox, createConfigFromPolicy, the pre-namespace policy getters and spawnSandboxFromConfig. No pipeline builds it, so the breakage went unnoticed. Porting it to v1 would also mean redesigning its raw-config and "Advanced" modes, because v1 accepts only a typed ContainerRequest, not a raw versioned ContainerConfig.

Details

  • Delete all 13 tracked Playground files, including its npm lockfile.
  • Drop the Playground lockfile from the lockfile list in CONTRIBUTING.md.

🔗 References

Tests

  • git grep -i playground returned no matches after the change.
  • No build or test inputs reference tests/playground; no pipeline, workflow or script change was needed.
Microsoft Reviewers: Open in CodeFlow

This PR deletes tests/playground, the Electron app for trying MXC policies
interactively. Since #1355 it has called SDK entry points that no longer
exist, including the empty root export, spawnSandbox,
createConfigFromPolicy and spawnSandboxFromConfig. No pipeline built it, so
the breakage went unnoticed.

Details

* Delete all 13 tracked Playground files, including its npm lockfile.
* Drop the Playground lockfile from the CONTRIBUTING lockfile list.

Tests

* git grep -i playground finds no remaining references.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ce647283-a4dd-44d4-995a-3e0ac8f5d574
Generated-with: claude-opus-5.5
Copilot AI balanced review requested due to automatic review settings October 21, 2026 18:13
@MGudgin
Gudge (MGudgin) requested a review from a team as a code owner October 21, 2026 18:13
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The retirement is self-contained, with no identified blocking defects or impact on supported SDKs and CI inputs.

No open issues 🎉

What changed in this PR

Removes the obsolete Electron Playground without changing supported MXC SDKs or backend behavior.

Changes:

  • Deletes the Playground application, build configuration, and supporting documentation.
  • Removes its lockfile entry from contributor guidance.
File Description
tests/​playground/​tsconfig.renderer.json Removes renderer compiler configuration.
tests/​playground/​tsconfig.main.json Removes main-process compiler configuration.
tests/​playground/​test-scripts/​winhttp-proxy-test.ps1 Removes Playground proxy test script.
tests/​playground/​src/​renderer/​styles.css Removes application styles.
tests/​playground/​src/​renderer/​index.html Removes application interface.
tests/​playground/​src/​renderer/​app.ts Removes interactive scenarios and controls.
tests/​playground/​src/​main/​preload.ts Removes renderer communication bridge.
tests/​playground/​src/​main/​main.ts Removes Electron startup and SDK integration.
tests/​playground/​playground-limitations.md Removes obsolete compatibility documentation.
tests/​playground/​package.json Removes application dependencies and packaging configuration.
tests/​playground/​build-renderer.js Removes static asset build script.
tests/​playground/​.gitignore Removes application-specific ignore rules.
CONTRIBUTING.md Removes the Playground lockfile listing.

Review effort: Balanced

@MGudgin
Gudge (MGudgin) merged commit be94b4b into main Oct 21, 2026
31 checks passed
@MGudgin
Gudge (MGudgin) deleted the user/gudge/remove_playground branch October 21, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants