chore: minimize the virtualized-lists fork - #3026
Open
Saad Najmi (Saadnajmi) wants to merge 1 commit into
Open
Conversation
Saad Najmi (Saadnajmi)
marked this pull request as ready for review
July 29, 2026 21:08
Move macOS keyboard selection into FlatList and sync the virtualized-lists implementation with upstream, retaining only native vertical inversion support. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2a1abab3-6a1a-43f9-afea-e18a5f862f6a
Saad Najmi (Saadnajmi)
changed the title
Saad Najmi (Saadnajmi)
force-pushed
the
saadnajmi/unfork-virtualized-lists
branch
from
August 4, 2026 06:20
36ffd2b to
015e09c
Compare
Comment on lines
-240
to
-244
| if (Platform.OS === 'macos') { | ||
| // [macOS | ||
| result = React.cloneElement(result, {collapsable: false}); | ||
| } // macOS] | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
We shouldn't remove this, I think this was a performance optimization made separately
Tommy Nguyen (tido64)
approved these changes
Aug 5, 2026
Comment on lines
+117
to
+139
| /** | ||
| * Called when the selected row changes. | ||
| * | ||
| * @platform macos | ||
| */ | ||
| onSelectionChanged?: | ||
| | ((info: { | ||
| previousSelection: number; | ||
| newSelection: number; | ||
| item: ItemT | ReadonlyArray<ItemT> | null | undefined; | ||
| }) => void) | ||
| | null | ||
| | undefined; | ||
|
|
||
| /** | ||
| * Called when Enter is pressed on the selected row. | ||
| * | ||
| * @platform macos | ||
| */ | ||
| onSelectionEntered?: | ||
| | ((item: ItemT | ReadonlyArray<ItemT> | null | undefined) => void) | ||
| | null | ||
| | undefined; |
Member
There was a problem hiding this comment.
Are these names taken from somewhere? Web API uses onChange for both. Looks like we've always had these so changing them now would break stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@react-native-macos/virtualized-listsimplementation and tests with the React Native merge-baseisSelected, andselectRowAtIndexintoFlatListScrollViewgeneric; it only preserves native children when macOS native inversion is activeWhy
The fork duplicated upstream list implementation primarily for keyboard selection and native inversion. Selection is FlatList/listbox semantics, while VirtualizedList should remain generic virtualization infrastructure. Native vertical inversion still needs a minimal strategy clause because upstream transform inversion does not provide correct macOS scrolling interactions.
After this change, the virtualized-lists fork differs from the upstream merge-base in only
Lists/VirtualizedList.js, where vertical macOS inversion omits transform styles.Behavior notes
FlatListkeeps the existing macOS keyboard-selection API.SectionListand directVirtualizedListno longer expose the unused keyboard-selection API.scaleX(-1)because AppKit native inversion is vertical only.Validation
yarn flow-check