Skip to content

fix: vertically center single-line TextInput content #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saad Najmi (Saadnajmi) merged 2 commits into from
Aug 4, 2026
Merged

fix: vertically center single-line TextInput content #3074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95242de
fix(macos): vertically center single-line TextInput content
Saadnajmi Aug 4, 2026
522769e
docs(macos): explain TextInput vertical centering
Saadnajmi Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-native/Libraries/Text/TextInput/Singleline/RCTUITextField.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@ @implementation RCTUITextFieldCell

- (NSRect)titleRectForBounds:(NSRect)rect
{
return UIEdgeInsetsInsetRect([super titleRectForBounds:rect], self.textContainerInset);
NSRect titleRect = UIEdgeInsetsInsetRect([super titleRectForBounds:rect], self.textContainerInset);
// Center the intrinsic text height within the padded control bounds.
CGFloat contentHeight = self.cellSize.height;
if (contentHeight < titleRect.size.height) {
titleRect.origin.y += (titleRect.size.height - contentHeight) / 2;
titleRect.size.height = contentHeight;
}
return titleRect;
}

- (void)editWithFrame:(NSRect)rect inView:(NSView *)controlView editor:(NSText *)textObj delegate:(id)delegate event:(NSEvent *)event
Expand Down
9 changes: 8 additions & 1 deletion packages/react-native/Libraries/Text/TextInput/Singleline/macOS/RCTUISecureTextField.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,14 @@ @implementation RCTUISecureTextFieldCell

- (NSRect)titleRectForBounds:(NSRect)rect
{
return UIEdgeInsetsInsetRect([super titleRectForBounds:rect], self.textContainerInset);
NSRect titleRect = UIEdgeInsetsInsetRect([super titleRectForBounds:rect], self.textContainerInset);
// Center the intrinsic text height within the padded control bounds.
CGFloat contentHeight = self.cellSize.height;
if (contentHeight < titleRect.size.height) {
titleRect.origin.y += (titleRect.size.height - contentHeight) / 2;
titleRect.size.height = contentHeight;
}
return titleRect;
}

- (void)editWithFrame:(NSRect)rect inView:(NSView *)controlView editor:(NSText *)textObj delegate:(id)delegate event:(NSEvent *)event
Expand Down
Loading