refactor: use built-in Error.isError

[Tommy Nguyen (tido64)]

Description

Use built-in Error.isError instead of instanceof.

Note that this was recently introduced in Node 24.3. We cannot use it in public-facing code.

Platforms affected

• Android
• iOS
• macOS
• visionOS
• Windows

Test plan

n/a

[Jason Morse (JasonVMo)]

Should we create a wrapper abstraction like?:

export function isError(e: unknown): e is Error {
  return e != null && (e as { isError?: unknown }).isError || e instanceof Error);
}

Generally we can catch the truthy value of isError which will match the new behavior but fall through to the older instance of behavior. It seems like the isError check effectively widens the type.

[Tommy Nguyen (tido64)]

Should we create a wrapper abstraction like?:

For this scenario specifically, we can use Error.isError because they're all for internal use only. There is exactly one instance, in public-facing code, where we use an abstraction:

react-native-test-app/packages/app/windows/project.mjs

Lines 36 to 38 in a924b3a

	function isErrorLike(e) {
	return typeof e === "object" && e !== null && "name" in e && "message" in e;
	}

Which can benefit from being replaced with Error.isError (because we don't care what kind of error it is). But we can change it when we bump minimum Node version.