feat(csharp): expose RVM instruction budget setter - #811
Merged
Anand Krishnamoorthi (anakrish) merged 1 commit intoSep 9, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Maksym (@maksym-mishchenko) Thanks for fixing this gap. LGTM. |
Anand Krishnamoorthi (anakrish)
approved these changes
Sep 9, 2026
Copilot started reviewing on behalf of
Anand Krishnamoorthi (anakrish)
September 9, 2026 10:12
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The binding correctly forwards validated values and is thoroughly tested and documented.
Pull request overview
Exposes the native RVM instruction budget to C# callers while preserving existing execution semantics.
Changes:
- Adds
Rvm.SetMaxInstructions(ulong)with pointer-width validation. - Adds comprehensive native and C# lifecycle tests.
- Documents budget behavior and error handling.
File summaries
| File | Description |
|---|---|
src/rvm/vm/execution.rs |
Adds instruction-budget behavior tests. |
docs/rvm/vm-runtime.md |
Documents runtime budget semantics. |
bindings/csharp/Regorus/Rvm.cs |
Adds the public C# setter. |
bindings/csharp/Regorus.Tests/RvmProgramTests.cs |
Adds C# integration and boundary tests. |
bindings/csharp/README.md |
Adds usage guidance. |
bindings/csharp/API.md |
Updates the public API reference. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Anand Krishnamoorthi (anakrish)
merged commit Sep 9, 2026
aae56a0
into
microsoft:main
60 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the existing native instruction-budget control to C# callers through
Rvm.SetMaxInstructions(ulong). The method preserves native counting and exhaustion behavior and rejects values that exceed the native pointer width. No native runtime behavior or ABI changes are included.