Repository navigation
[rush-daemon] Stop --verbose / --parallelism / --timeline from reloading the warm graph #6063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Sean Larkin (TheLarkInn)
merged 3 commits into
main
from
thelarkinn-fix-rushd-flag-reload
Sep 24, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
common/changes/@microsoft/rush/flag-reload_2026-09-24.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@microsoft/rush", | ||
| "comment": "Exclude `--verbose`, `--parallelism` and `--timeline` from the daemon engine parameter identity and expose them as per-request settings, so these flags no longer force the Rush daemon to reload its warm operation graph.", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "@microsoft/rush", | ||
| "email": "selarkin@microsoft.com" | ||
| } |
11 changes: 11 additions & 0 deletions
11
common/changes/@rushstack/rush-daemon/flag-reload_2026-09-24.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@rushstack/rush-daemon", | ||
| "comment": "Apply `--verbose` and `--parallelism` to the warm graph per iteration instead of reloading the graph, and only coalesce requests that share these settings.", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "@rushstack/rush-daemon", | ||
| "email": "selarkin@microsoft.com" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
libraries/rush-daemon/src/test/WorkspaceRequestScopedParameters.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license. | ||
| // See LICENSE in the project root for license information. | ||
|
|
||
| import { WorkspaceInputChangeTier, type IOperationGraph } from '@microsoft/rush-lib'; | ||
|
|
||
| import { DaemonGraphTestFixture } from './DaemonGraphTestFixture'; | ||
| import { setDaemonPolicy } from './WarmGenerationTestUtilities'; | ||
|
|
||
| jest.setTimeout(30_000); | ||
|
|
||
| it('applies --verbose and --parallelism per request without reloading the warm graph', async () => { | ||
| const fixture = await DaemonGraphTestFixture.createAsync((created) => setDaemonPolicy(created, {})); | ||
| try { | ||
| const buildAsync = async (...extra: string[]): Promise<void> => { | ||
| const result = await fixture.runAsync(['build', '--to', 'b', ...extra]); | ||
| expect(result.terminal).toMatchObject({ payload: { exitCode: 0 } }); | ||
| }; | ||
| await buildAsync(); | ||
| expect(fixture.runs()).toEqual(['a', 'b']); | ||
| const generation: number = fixture.host.workspaceGeneration; | ||
| const graph: IOperationGraph | undefined = fixture.session.operationGraph; | ||
| const defaultParallelism: number = graph!.parallelism; | ||
| const expectWarm = (): void => { | ||
| expect(fixture.host.workspaceGeneration).toBe(generation); | ||
| expect(fixture.session.operationGraph).toBe(graph); | ||
| expect(fixture.host.workspaceStatus.lastReloadTier).toBe(WorkspaceInputChangeTier.Reuse); | ||
| expect(fixture.runs()).toEqual(['a', 'b']); | ||
| }; | ||
|
|
||
| await buildAsync(); | ||
| expectWarm(); | ||
| await buildAsync('--verbose'); | ||
| expectWarm(); | ||
| expect(graph!.quietMode).toBe(false); | ||
| await buildAsync(); | ||
| expectWarm(); | ||
| expect(graph!.quietMode).toBe(true); | ||
| await buildAsync('-p', '1', '--timeline'); | ||
| expectWarm(); | ||
| expect(graph!.parallelism).toBe(1); | ||
| await buildAsync(); | ||
| expectWarm(); | ||
| expect(graph!.parallelism).toBe(defaultParallelism); | ||
|
|
||
| fixture.write('a/input.txt', 'two'); | ||
| await buildAsync('--verbose', '-p', '1'); | ||
| expect(fixture.host.workspaceGeneration).toBe(generation); | ||
| expect(fixture.runs()).toEqual(['a', 'b', 'a', 'b']); | ||
| } finally { | ||
| await fixture[Symbol.asyncDispose](); | ||
| } | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.