[heft] Faster startup, same API (v2) - #6097
Draft
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Draft
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Sean Larkin (TheLarkInn) wants to merge 1 commit into
Conversation
Heft loads less at startup. Config, CLI, plugin framework and shared libraries load lazily. Common paths skip ajv, heft-config-file, argparse and fast-glob. Plugins load task code when the task runs. Node's compile cache is enabled at startup. heft --help: 407 ms -> 86 ms. First task: 406 ms -> 90 ms. Peak RSS: -31%. API reports unchanged. CLI output byte-identical. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // which avoids loading fs-extra, and only use fs-extra to retry in the EMFILE/ENFILE case. | ||
| const { data, error } = await new Promise( | ||
| (resolve: (result: { data?: Buffer; error?: NodeJS.ErrnoException }) => void) => { | ||
| fs.readFile(filePath, (readError: NodeJS.ErrnoException | null, readData: Buffer) => |
| throw error; | ||
| } | ||
|
|
||
| return await _getFsx().readFile(filePath); |
Comment on lines
+5
to
+9
| // Enable the V8 compile cache before anything else is loaded (Node.js >= 22.8). It honors the | ||
| // NODE_COMPILE_CACHE and NODE_DISABLE_COMPILE_CACHE environment variables and fails silently. | ||
| try { | ||
| require('../lib-commonjs/bootstrap/CompileCache.js').tryEnableCompileCache(); | ||
| } catch {} |
Contributor
There was a problem hiding this comment.
Node compile cache is a double-edged sword. It adds a lot of extra file system operations unless the implementation has changed, so is really only effective for low numbers of large files.
| } | ||
|
|
||
| function defineParameter(provider: CommandLineParameterProvider, definition: IDefinition): CommandLineParameter { | ||
| const { kind, ...rest } = definition; |
Contributor
There was a problem hiding this comment.
Does passing kind to the define calls throw an error? Otherwise switch(definition.kind) should be able to act as a discriminant and just pass definition to each of the methods.
| // operations. | ||
| const executionManager: IOperationExecutionManager = this.#action.watch | ||
| ? new (await import('@rushstack/operation-graph')).OperationExecutionManager(operations) | ||
| : new (await import('../operations/OperationExecutionManager')).OperationExecutionManager(operations); |
Contributor
There was a problem hiding this comment.
If you want a forked operation manager for watch vs. not, do it in operation-graph
| * byte-identical results (help, errors, unusual syntax, etc.) is handled by the full ts-command-line based | ||
| * implementation in `HeftFullCommandLineParser`. | ||
| */ | ||
| export class HeftCommandLineParser { |
Contributor
There was a problem hiding this comment.
TL;DR, ts-command-line is overly expensive and needs a rewrite/optimization?
| } | ||
|
|
||
| class SchemaAnalyzer { | ||
| private readonly _root: ISchemaObject; |
Contributor
There was a problem hiding this comment.
Use ECMAScript private class fields, not typescript private
| /** | ||
| * node:child_process (which also loads the net, dgram and stream implementations) is only loaded when needed. | ||
| */ | ||
| function _getChildProcess(): typeof child_process { |
Contributor
There was a problem hiding this comment.
This sort of thing should be done by transpiling with SWC and setting lazy: true
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heft starts faster. Same API.
Before → after
heft 1.3.1 → this PR. Linux x64 (WSL2), Node 22, 50 interleaved runs, pinned CPUs.
heft --help--helpStill 3–4× faster than 1.3.1 with
NODE_COMPILE_CACHEon.What changed
Compatibility
Notes