SARIF ruleIndex and artifactLocation.index values are local reference… - #3149
Open
Jan Schlosser (castler) wants to merge 1 commit into
Open
Jan Schlosser (castler) wants to merge 1 commit into
Jan Schlosser (castler) wants to merge 1 commit into
Conversation
Jan Schlosser (castler)
force-pushed
the
fix/deduplicate-after-remapping
branch
from
August 13, 2026 13:30
7de64ae to
a821b1d
Compare
Author
|
@microsoft-github-policy-service agree |
Jan Schlosser (castler)
marked this pull request as ready for review
August 13, 2026 13:35
Jan Schlosser (castler)
requested review from
Aasim Malladi (aasim) and
cfaucon
as code owners
August 13, 2026 13:35
…s into each input run. MergeCommand previously compared raw Result objects before RunMergingVisitor remapped those references, so semantically identical findings from separate logs could receive different indices and survive deduplication. This is observable when merging CodeQL SARIF generated from two different databases. Perform optional deduplication after RunMergingVisitor has canonicalized referenced rules, artifacts, logical locations, and invocations. Keep the behavior opt-in for other RunMergingVisitor consumers, and add a regression test covering equivalent results with different local rule and artifact indices. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SARIF ruleIndex and artifactLocation.index values are local references into each input run.
MergeCommand previously compared raw Result objects before RunMergingVisitor remapped those references, so semantically identical findings from separate logs could receive different indices and survive deduplication.
This is observable when merging CodeQL SARIF generated from two different databases.
Perform optional deduplication after RunMergingVisitor has canonicalized referenced rules, artifacts, logical locations, and invocations. Keep the behavior opt-in for other RunMergingVisitor consumers, and add a regression test covering equivalent results with different local rule and artifact indices.