Fix C# ModelProvider constructor virtual dispatch - #11474
Open
ArcturusZhang wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b3780828-9610-442a-b2ce-a43c6094e0b5
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
commit: |
Contributor
|
No changes needing a change description found. |
ArcturusZhang
marked this pull request as ready for review
July 30, 2026 05:48
ArcturusZhang
requested review from
JoshLove-msft,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
July 30, 2026 05:48
Member
Author
jorgerangel-msft
left a comment
jorgerangel-msft
left a comment
Contributor
There was a problem hiding this comment.
Looks like regen preview failed due to auth issues. I retriggered it. Otherwise changes lgtm
| Assert.AreEqual("ProjectedModel", provider!.Name); | ||
| } | ||
|
|
||
| private sealed class DerivedModelProviderReadingOwnName : ModelProvider |
Contributor
There was a problem hiding this comment.
nit: can we please reuse the existing TestModelProvider type and just update the parameters it accepts?
jorgerangel-msft
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildName()while a derivedModelProvideris only partially constructedFixes #11472
Validation
npm run buildnpm testnpm run copeng/scripts/Generate.ps1