Enable verbatimModuleSyntax on medium-tier packages - #11481
Merged
timotheeguerin merged 4 commits intoJul 30, 2026
Conversation
Enable verbatimModuleSyntax in tsconfig.json for protobuf, http-specs, spector and typespec-vscode, converting type-only imports and re-exports to import type / export type accordingly.
microsoft-github-policy-service
Bot
added
ide
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
… CJS
Under verbatimModuleSyntax, a fully-inline-type import (import { type X })
is preserved as a side-effect import, which esbuild bundles. That pulled
@typespec/compiler (with top-level await) into the CJS extension bundle and
broke the build. Convert to import type to drop the module reference.
|
You can try these changes here
|
timotheeguerin
marked this pull request as ready for review
July 30, 2026 17:08
timotheeguerin
requested review from
RodgeFu,
bterlson,
catalinaperalta,
iscai-msft,
lirenhe,
lmazuel,
markcowl and
xirzec
as code owners
July 30, 2026 17:08
timotheeguerin
enabled auto-merge
July 30, 2026 18:45
iscai-msft
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third pass of the
verbatimModuleSyntaxrollout, covering the "medium tier" packages. Follows #11479 (easy tier) and #11480 (small tier). Adds"verbatimModuleSyntax": trueto each package'stsconfig.jsonand converts type-only imports/re-exports toimport type/export type.Packages migrated
@typespec/protobuf@typespec/http-specs@typespec/spectortypespec-vscodeHow
oxlint typescript/consistent-type-importsandtypescript/consistent-type-exports,--type-aware, separate-type-imports style).Out of scope
tsconfig.base.jsonis intentionally untouched (that would force all packages at once).http-client-csharp,http-client-java,http-client-python).http-client,http-client-js,tspd,http-server-js,http,openapi3,compiler) are deferred to later passes.Validation
tsc -bemit build for protobuf/http-specs/spector;tsc --noEmittype-check for typespec-vscode (esbuild build)prettier --checkon all changed filesoxlint --type-aware --deny-warningson all 4 packageschronus verify(changeset covers the 3 publishable packages;typespec-vscodeis private)