Skip to content

[jemalloc] Support non-Windows - #25227

Closed
Jack·Boos·Yu (JackBoosY) wants to merge 11 commits into
microsoft:masterfrom
JackBoosY:dev/jack/17409
Closed

Jack·Boos·Yu (JackBoosY) wants to merge 11 commits into
microsoft:masterfrom
JackBoosY:dev/jack/17409

Conversation

@JackBoosY

Copy link
Copy Markdown
Contributor

Now the upstream cmake code doesn't support non-Windows, add support now.

Upstream PR: jemalloc/jemalloc-cmake#4

Fixes #17409

@JackBoosY Jack·Boos·Yu (JackBoosY) added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels Jun 14, 2022

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/jemalloc/portfile.cmake

@JackBoosY
Jack·Boos·Yu (JackBoosY) marked this pull request as draft June 14, 2022 09:34
Comment thread ports/jemalloc/add-unix-support.patch Outdated
@Neumann-A

Copy link
Copy Markdown
Contributor

will create a merge conflict with #25009

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for jemalloc have changed but the version was not updated
version: 4.3.1#6
old SHA: ed300e5586d3558b58e25b909103810eeb65d812
new SHA: 9927f742f31ed7298de5152335eadec99fc672ed
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/jemalloc/portfile.cmake

@JackBoosY
Jack·Boos·Yu (JackBoosY) marked this pull request as ready for review June 15, 2022 05:43
@JackBoosY Jack·Boos·Yu (JackBoosY) added the depends:upstream-changes Waiting on a change to the upstream project label Jun 15, 2022

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/jemalloc/portfile.cmake

@JackBoosY

Copy link
Copy Markdown
Contributor Author

In favor of #25009.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:upstream-changes Waiting on a change to the upstream project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[jemalloc] build failure, "versions" feature can't recognize port's current version format 4.3.1-4 in "overrides" section

3 participants