[ktexttemplate] add new port and deprecate grantlee - #53512
Jack·Boos·Yu (JackBoosY) wants to merge 16 commits into
Conversation
| "homepage": "https://github.com/steveire/grantlee", | ||
| "homepage": "https://invent.kde.org/frameworks/ktexttemplate", | ||
| "license": "LGPL-2.1-or-later", | ||
| "supports": "!staticcrt & !xbox", |
There was a problem hiding this comment.
grantlee was renamed to ktexttemplate so I think the support field should be keep.
|
Never mind, it's just a test case. |
Billy O'Neal (@BillyONeal) I don't get this point, I have already updated all the baseline versions, is this related to the deleted port grantlee? |
|
Billy O'Neal (@BillyONeal) Ready for review now. |
Billy O'Neal (BillyONeal)
left a comment
There was a problem hiding this comment.
Hi there, thanks for the "new" port :) GPT 5.6 Sol found:
- Fix runtime plugin placement.
ports/ktexttemplate/fix-plugin-installation.patchinstalls the plugin DLLs directly inbin, but upstream's loader appendskf6/ktexttemplate/to every search root.
Unfortunately I don't think there's a good fix for this right now; vcpkg really needs a better hook for z-applocal to make this doable.
- Replace generated usage with accurate custom usage.
vcpkg print-usage ktexttemplateadvertisesKF6::i18ntags,KF6::loadertags, andKF6::defaulttags, which are imported module DLLs and cannot be linked on Windows. Although this target-export shape is inherited from Grantlee, Grantlee's config location was not recognized by the heuristic and generated no usage text. KTextTemplate's recognized config now exposes a command that fails exactly as printed. The usage should link onlyKF6::TextTemplate.
I think it would be good to fix the usage before merging this, but otherwise I think this is ready to go.
| -set( KTextTemplate_INSTALL_PLUGINDIR ${KDE_INSTALL_PLUGINDIR}/kf6/ktexttemplate ) | ||
| +set( KTextTemplate_INSTALL_PLUGINDIR bin ) |
There was a problem hiding this comment.
FYI GPT 5.6 thinks this doesn't actually work
|
FTR we put Qt plugins into |
If the other kf6-whatever-actually-named-kwhatever entries are doing it we should, yes. |
|
I'm so busy recently, forgive I paused this PR progress. |
Okay so those dlls should be moved to |
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.Fixes #41818