Skip to content

[libevent, pistache] Update pistache to 0.4.25. - #53970

Merged
Billy O'Neal (BillyONeal) merged 6 commits into
microsoft:masterfrom
BillyONeal:ubuntu-resolute-pistache
Sep 23, 2026
Merged

Billy O'Neal (BillyONeal) merged 6 commits into
microsoft:masterfrom
BillyONeal:ubuntu-resolute-pistache

Conversation

@BillyONeal

Copy link
Copy Markdown
Member

See also #43852

The version of Pistache we were shipping does not build on Ubuntu 26.04 "Resolute Raccoon". Rather than try to patch around the problem, we should not be trying to ship 6 year old copies.

Unlike the previous attempt I'm not going to try adding features and controls, just bringing forward what was supported before. This is not a statement against those features, I'm just trying to do the minimal update to make Resolute work.

Also fixed libevent's pkg-config bindings to make debug builds work.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 86073671-3028-4d0c-9969-970affb896b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 86073671-3028-4d0c-9969-970affb896b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 86073671-3028-4d0c-9969-970affb896b1
Apply upstream's static library fix so static CRT triplets can build, while excluding Android and Windows architectures blocked by upstream build-system limitations.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: b11d5b7b-3acd-48f0-8f16-58c6f87d886e
@BillyONeal
Billy O'Neal (BillyONeal) marked this pull request as ready for review September 22, 2026 08:08
@BillyONeal

Copy link
Copy Markdown
Member Author

GPT 5.6 Sol notes:

  • Prevent the Windows build/install from running upstream's event-log installation scripts. The current build writes under C:\Program Files, invokes wevtutil, and creates an HKCU registry key. vcpkg ports must not modify the host system. Patch or configure the upstream build so these targets/install scripts are disabled while retaining any resource DLL that is legitimately part of the package.
  • Fix the Windows dynamic-library naming mismatch. Release and Debug consumers link successfully, but their executables import pistache.dll; the package only contains pistache-0.4.dll, so both pkg-config and direct-link examples terminate with STATUS_DLL_NOT_FOUND. The import library and installed DLL must use the same name.
  • Static Libevent pkg-config consumers still fail because libevent.pc omits iphlpapi, leaving if_nametoindex unresolved. This issue predates the PR; the new rewrite correctly changes Debug library names but does not affect the system-library list.

@BillyONeal
Billy O'Neal (BillyONeal) marked this pull request as draft September 22, 2026 22:53
@BillyONeal

Copy link
Copy Markdown
Member Author

pistacheio/pistache#1355

@BillyONeal
Billy O'Neal (BillyONeal) marked this pull request as ready for review September 22, 2026 23:26
Comment thread ports/pistache/vcpkg.json
"description": "Pistache is a modern and elegant HTTP and REST framework for C++. It is entirely written in pure-C++17 and provides a clear and pleasant API",
"homepage": "https://github.com/pistacheio/pistache",
"license": "Apache-2.0",
"supports": "!android & !windows",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this accurate? The GitHub readme says it supports Windows. It does not Android though.

Pistache supports Linux, macOS, Windows and BSD (FreeBSD, OpenBSD, and NetBSD). To use in macOS, Windows, or BSD, see the respective files: Building on macOS.txt, Building on Windows.txt or Building on BSD.txt.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream claims to support Windows but their meson build system does not produce usable results, that's why I filed pistacheio/pistache#1355

This is still an improvement vs. the status quo because the previous port only supported Linux

@BillyONeal
Billy O'Neal (BillyONeal) merged commit b61d330 into microsoft:master Sep 23, 2026
16 checks passed
@BillyONeal
Billy O'Neal (BillyONeal) deleted the ubuntu-resolute-pistache branch September 23, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants