[libevent, pistache] Update pistache to 0.4.25. - #53970
Merged
Billy O'Neal (BillyONeal) merged 6 commits intoSep 23, 2026
Merged
Billy O'Neal (BillyONeal) merged 6 commits into
Billy O'Neal (BillyONeal) merged 6 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 86073671-3028-4d0c-9969-970affb896b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 86073671-3028-4d0c-9969-970affb896b1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 86073671-3028-4d0c-9969-970affb896b1
Billy O'Neal (BillyONeal)
force-pushed
the
ubuntu-resolute-pistache
branch
from
September 18, 2026 00:56
7d5ee25 to
3ad4b38
Compare
Billy O'Neal (BillyONeal)
marked this pull request as draft
September 18, 2026 01:46
Apply upstream's static library fix so static CRT triplets can build, while excluding Android and Windows architectures blocked by upstream build-system limitations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b11d5b7b-3acd-48f0-8f16-58c6f87d886e
Billy O'Neal (BillyONeal)
marked this pull request as ready for review
September 22, 2026 08:08
Member
Author
|
GPT 5.6 Sol notes:
|
Billy O'Neal (BillyONeal)
marked this pull request as draft
September 22, 2026 22:53
Member
Author
Billy O'Neal (BillyONeal)
marked this pull request as ready for review
September 22, 2026 23:26
| "description": "Pistache is a modern and elegant HTTP and REST framework for C++. It is entirely written in pure-C++17 and provides a clear and pleasant API", | ||
| "homepage": "https://github.com/pistacheio/pistache", | ||
| "license": "Apache-2.0", | ||
| "supports": "!android & !windows", |
There was a problem hiding this comment.
Is this accurate? The GitHub readme says it supports Windows. It does not Android though.
Pistache supports Linux, macOS, Windows and BSD (FreeBSD, OpenBSD, and NetBSD). To use in macOS, Windows, or BSD, see the respective files: Building on macOS.txt, Building on Windows.txt or Building on BSD.txt.
Member
Author
There was a problem hiding this comment.
Upstream claims to support Windows but their meson build system does not produce usable results, that's why I filed pistacheio/pistache#1355
This is still an improvement vs. the status quo because the previous port only supported Linux
Mahmoud Saleh (MahmoudGSaleh)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #43852
The version of Pistache we were shipping does not build on Ubuntu 26.04 "Resolute Raccoon". Rather than try to patch around the problem, we should not be trying to ship 6 year old copies.
Unlike the previous attempt I'm not going to try adding features and controls, just bringing forward what was supported before. This is not a statement against those features, I'm just trying to do the minimal update to make Resolute work.
Also fixed libevent's pkg-config bindings to make debug builds work.
./vcpkg x-add-version --alland committing the result.