[gtsam] Update to 4.3.0 - #53992
Open
SunBlack (SunBlack) wants to merge 2 commits into
Open
[gtsam] Update to 4.3.0#53992SunBlack (SunBlack) wants to merge 2 commits into
SunBlack (SunBlack) wants to merge 2 commits into
Conversation
SunBlack (SunBlack)
force-pushed
the
gtsam
branch
from
September 20, 2026 01:11
55dcf98 to
3042ac0
Compare
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
GPT 5.6 Sol hates that the boost bits were turned off by default but I disagree with it so not even going to quote. It also says:
- Upstream 4.3.0's
HandleSuiteSparse.cmakeprobes for CCOLAMD and CHOLMOD and changes compiled functionality according to whatever is already installed. The port neither declares those dependencies nor forces them off.- Correct third-party handling and licensing. GTSAM 4.3.0 always builds and installs the vendored Cephes implementation described in
gtsam/3rdparty/cephes/README.md, including a separatecephes-gtsamDLL and headers, butvcpkg.jsonstill declares onlyBSD-3-Clauseandportfile.cmakedoes not install Cephes's MIT license. The package also continues to compile bundled Spectra and CCOLAMD/SuiteSparse_config.
Both these problems are addressed in SunBlack#91 , would you take a look?
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.