Skip to content

[gtsam] Update to 4.3.0 - #53992

Open
SunBlack (SunBlack) wants to merge 2 commits into
microsoft:masterfrom
SunBlack:gtsam
Open

SunBlack (SunBlack) wants to merge 2 commits into
microsoft:masterfrom
SunBlack:gtsam

Conversation

@SunBlack

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT 5.6 Sol hates that the boost bits were turned off by default but I disagree with it so not even going to quote. It also says:

  • Upstream 4.3.0's HandleSuiteSparse.cmake probes for CCOLAMD and CHOLMOD and changes compiled functionality according to whatever is already installed. The port neither declares those dependencies nor forces them off.
  • Correct third-party handling and licensing. GTSAM 4.3.0 always builds and installs the vendored Cephes implementation described in gtsam/3rdparty/cephes/README.md, including a separate cephes-gtsam DLL and headers, but vcpkg.json still declares only BSD-3-Clause and portfile.cmake does not install Cephes's MIT license. The package also continues to compile bundled Spectra and CCOLAMD/SuiteSparse_config.

Both these problems are addressed in SunBlack#91 , would you take a look?

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants