[libnatpmp] Add new port - #53998
Merged
Billy O'Neal (BillyONeal) merged 4 commits intoSep 23, 2026
Merged
[libnatpmp] Add new port#53998
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Billy O'Neal (BillyONeal)
requested changes
Sep 23, 2026
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
GPT 5.6 Sol reports:
The supported Windows static package cannot be consumed. The installed upstream
natpmp_declspec.hdefaults public APIs to__declspec(dllimport)on Windows unlessNATPMP_STATICLIBis defined, but neither the installed metadata nor direct usage supplies that definition. Consequently, both Release and Debug consumers fail to link through direct usage and pkg-config.
Would you consider merging Kiptoo-Deus#1 which fixes this?
Thanks for the new port!
[libnatpmp] Imbue static linkage in installed header
Contributor
Author
|
Thanks Billy O'Neal (@BillyONeal)! Merged your fix (Kiptoo-Deus#1). CI is green across all triplets, including the Windows static ones. Ready for another look when you have time. |
Joel Kiptoo (Kiptoo-Deus)
requested a review
from Billy O'Neal (BillyONeal)
September 23, 2026 06:24
Billy O'Neal (BillyONeal)
enabled auto-merge (squash)
September 23, 2026 17:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a port for libnatpmp, a client-side NAT traversal library implementing NAT-PMP (BSD-3-Clause). Resolves #52796.
Versioning. Upstream has no git tags, and its
VERSIONfile still reads20120821while the repository was last updated in April 2025. The port pins commit134fc89ewith"version-date": "2025-04-03". Other distributions version this library by date for the same reason — Arch, for instance, packages it as20230423.No CMake package config. Upstream's
CMakeLists.txtinstalls no export set and generates no config file, sovcpkg_cmake_config_fixupis not called. Consumers use thenatpmppkg-config module, which vcpkg's automatically generated usage text already reports correctly.The
natpmpcexecutable upstream installs is relocated totools/libnatpmp/viavcpkg_copy_tools.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says —LICENSEreads "BSD 3-Clause License, Copyright (c) 2007-2022, Thomas BERNARD"../vcpkg x-add-version --alland committing the result.